Skip to content

Fix double wrapping of algebraic model answers #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippImhof merged 1 commit into from
Apr 4, 2026
Merged

Fix double wrapping of algebraic model answers #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions classes/local/formulas_part.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,12 +527,9 @@ public function get_evaluated_answers(): array {
// If the answer type is algebraic, substitute all non-algebraic variables by
// their numerical value.
if ($isalgebraic) {
foreach ($this->evaluatedanswers as &$answer) {
$answer = $this->evaluator->substitute_variables_in_algebraic_formula($answer);
foreach ($this->evaluatedanswers as $index => $answer) {
$this->evaluatedanswers[$index] = $this->evaluator->substitute_variables_in_algebraic_formula($answer);
}
// In case we later write to $answer, this would alter the last entry of the $modelanswers
// array, so we'd better remove the reference to make sure this won't happend.
unset($answer);
}

return $this->evaluatedanswers;
Expand All @@ -546,7 +543,7 @@ public function get_evaluated_answers(): array {
* @return array array containing wrapped formulas
*/
private static function wrap_algebraic_formulas_in_quotes(array $formulas): array {
foreach ($formulas as &$formula) {
foreach ($formulas as $index => $formula) {
// If the formula is aready wrapped in quotes, we throw an Exception, because that
// should not happen. It will happen, if the student puts quotes around their response, but
// we want that to be graded wrong. The exception will be caught and dealt with upstream,
Expand All @@ -555,11 +552,8 @@ private static function wrap_algebraic_formulas_in_quotes(array $formulas): arra
throw new Exception();
}

$formula = '"' . $formula . '"';
$formulas[$index] = '"' . $formula . '"';
}
// In case we later write to $formula, this would alter the last entry of the $formulas
// array, so we'd better remove the reference to make sure this won't happen.
unset($formula);

return $formulas;
}
Expand Down Expand Up @@ -828,13 +822,11 @@ public function get_correct_response(bool $forfeedback = false): array {
$answers = $this->get_evaluated_answers();

// Numeric answers should be localized, if that functionality is enabled.
foreach ($answers as &$answer) {
foreach ($answers as $index => $answer) {
if (is_numeric($answer)) {
$answer = qtype_formulas::format_float($answer);
$answers[$index] = qtype_formulas::format_float($answer);
}
}
// Make sure we do not accidentally write to $answer later.
unset($answer);

// If we have a combined unit field, we return both the model answer plus the unit
// in "i_". Combined fields are only possible for parts with one signle answer.
Expand Down
Loading