Skip to content

fix(#407): Share dialog says 'Only you.' under 'Who has access' while the item has public l - #416

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-407
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-407

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #407

ShareDialog now says 'Only you.' only without members and without an active public link (shared isActiveLink helper, LinkManager emits its loaded links, new share.linksOnly sentence in all three locales). The #407 E2E test closes the dialog with its Close button because the focused member picker swallows the first Esc. The collision E2E tests now run in their own folder so the phone's #225 windowing of the large shared home root cannot hide their rows.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1187 passed, 0 failed | e2e: 611 passed, 0 failed
  • Red/green check on declared tests: e2e/shares.spec.ts, e2e/collision.spec.ts
red/green output
RED without the change:
ome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/shares--407-the-share-dial-20f00-thout-an-active-public-link-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/shares--407-the-share-dial-20f00-thout-an-active-public-link-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/shares.spec.ts:268:1 › #407: the share dialog says "Only you." only without members and without an active public link 
    [mobile-chrome] › e2e/shares.spec.ts:268:1 › #407: the share dialog says "Only you." only without members and without an active public link 
  20 passed (46.1s)


GREEN with the change:
 not offered (2.2s)
  ✓  18 [mobile-chrome] › e2e/shares.spec.ts:93:1 › the share dialog works with the keyboard alone, and the member picker filters by name (2.1s)
  ✓  19 [mobile-chrome] › e2e/shares.spec.ts:180:1 › #223: clicks land while the member list is open; the list overlays the form and never moves it (2.2s)
  ✓  20 [mobile-chrome] › e2e/shares.spec.ts:210:1 › #223: the member picker lists the members on focus; an unknown name keeps its inline note (2.1s)
  ✓  21 [mobile-chrome] › e2e/shares.spec.ts:236:1 › #235: a share revoked while the member has it open says so and leads back to "Shared with me" (1.6s)
  ✓  22 [mobile-chrome] › e2e/shares.spec.ts:268:1 › #407: the share dialog says "Only you." only without members and without an active public link (1.2s)

  22 passed (36.5s)

🤖 Generated with Claude Code

ShareDialog now says 'Only you.' only without members and without an active public link (shared isActiveLink helper, LinkManager emits its loaded links, new share.linksOnly sentence in all three locales). The #407 E2E test closes the dialog with its Close button because the focused member picker swallows the first Esc. The collision E2E tests now run in their own folder so the phone's #225 windowing of the large shared home root cannot hide their rows.

Refs #407

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 2c788b9 into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-407 branch October 20, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant