Repository navigation
fix(#407): Share dialog says 'Only you.' under 'Who has access' while the item has public l - #416
Merged
Merged
Conversation
ShareDialog now says 'Only you.' only without members and without an active public link (shared isActiveLink helper, LinkManager emits its loaded links, new share.linksOnly sentence in all three locales). The #407 E2E test closes the dialog with its Close button because the focused member picker swallows the first Esc. The collision E2E tests now run in their own folder so the phone's #225 windowing of the large shared home root cannot hide their rows. Refs #407 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #407
ShareDialog now says 'Only you.' only without members and without an active public link (shared isActiveLink helper, LinkManager emits its loaded links, new share.linksOnly sentence in all three locales). The #407 E2E test closes the dialog with its Close button because the focused member picker swallows the first Esc. The collision E2E tests now run in their own folder so the phone's #225 windowing of the large shared home root cannot hide their rows.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code