Skip to content

fix(#408, #409): Favourites, Shared with me, My shares, Tag views start ~50 px below the title (o - #417

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-408-409
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-408-409

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #408 #409

#408: moved the empty status line below the list in Favourites, Shared with me, My shares and the tag view (as in Trash), so their content starts as close under the title as Recent's; updated the shared-view screenshot baselines. #409: folder.created now quotes the name („{name}“ in German, “{name}” in English) in all three locales.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1187 passed, 0 failed | e2e: 614 passed, 0 failed
  • Red/green check on declared tests: e2e/title-gap.spec.ts, e2e/new-folder.spec.ts
red/green output
## #408
RED without the change:
──────────────────────────────────────

    Error Context: test-results/title-gap--408-Favourites--77ddc-e-under-the-title-as-Recent-desktop-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/title-gap--408-Favourites--77ddc-e-under-the-title-as-Recent-desktop-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/title-gap--408-Favourites--77ddc-e-under-the-title-as-Recent-desktop-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  1 failed
    [desktop-chrome] › e2e/title-gap.spec.ts:22:1 › #408: Favourites, Shared with me, My shares and a tag view start as close under the title as Recent 
  1 skipped


GREEN with the change:
position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/title-gap.spec.ts:22:1 › #408: Favourites, Shared with me, My shares and a tag view start as close under the title as Recent (1.2s)
  -  2 [mobile-chrome] › e2e/title-gap.spec.ts:22:1 › #408: Favourites, Shared with me, My shares and a tag view start as close under the title as Recent

  1 skipped
  1 passed (4.4s)


## #409
RED without the change:
97a04-n-German-and-“…”-in-English-mobile-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/new-folder--409-the-toast--97a04-n-German-and-“…”-in-English-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/new-folder--409-the-toast--97a04-n-German-and-“…”-in-English-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/new-folder.spec.ts:115:1 › #409: the toast quotes the new folder's name, „…“ in German and “…” in English 
    [mobile-chrome] › e2e/new-folder.spec.ts:115:1 › #409: the toast quotes the new folder's name, „…“ in German and “…” in English 


GREEN with the change:
on that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/new-folder.spec.ts:115:1 › #409: the toast quotes the new folder's name, „…“ in German and “…” in English (1.6s)
  ✓  2 [mobile-chrome] › e2e/new-folder.spec.ts:115:1 › #409: the toast quotes the new folder's name, „…“ in German and “…” in English (1.4s)

  2 passed (6.0s)

🤖 Generated with Claude Code

…rt ~50 p

#408: moved the empty status line below the list in Favourites, Shared with me, My shares and the tag view (as in Trash), so their content starts as close under the title as Recent's; updated the shared-view screenshot baselines. #409: folder.created now quotes the name („{name}“ in German, “{name}” in English) in all three locales.

Refs #408 #409

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 24f3fc6 into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-408-409 branch October 20, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant