Skip to content

fix(web): type the search updater in useFleetLocation - #696

Merged
ValgulNecron merged 1 commit into
masterfrom
claude/013-fleet-search-type
Oct 14, 2026
Merged

fix(web): type the search updater in useFleetLocation#696
ValgulNecron merged 1 commit into
masterfrom
claude/013-fleet-search-type

Conversation

@ValgulNecron

@ValgulNecron ValgulNecron commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Before: npm run typecheck:e2e failed with src/lib/fleet.ts(66,16): error TS7006 because the previous parameter of the router search updater was an implicit any under web/e2e/tsconfig.json.

After: previous is typed as Record<string, unknown>, and both tsc --noEmit -p tsconfig.json and -p e2e/tsconfig.json pass locally.

How: one-line annotation in web/src/lib/fleet.ts. No behaviour change. valgul approved this as its own PR on the spec 013 card.

🤖 Generated with Claude Code

Generated by Claude Code

@claude
fix(web): type the search updater in useClusterFilter
e9a5b2f 
previous was an implicit any under web/e2e/tsconfig.json, which broke npm run typecheck:e2e.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron added area: web React dashboard type: fix Bug fix labels Oct 14, 2026 — with Claude
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: GameplanePanel/Gameplane/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6baea8ac-27ea-421f-b077-7f5a145b0927
📥 Commits

Reviewing files that changed from the base of the PR and between f191103 and e9a5b2f.

📒 Files selected for processing: 1
  • web/src/lib/fleet.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ValgulNecron ValgulNecron self-assigned this Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

CI Report - e9a5b2f

run 38603914028 - attempt 2

0 failed - 9 passed - 22 skipped - 39m35s elapsed

Coverage

Module Measured Gate Margin
web L95.53 S94.07 B88.79 F91.78 L92 S92 B82 F76 +2.07

Changed

Area Files +/-
web/ 1 +1/-1

Slowest jobs

Job Duration
build e2e images 9m4s
e2e web live / arm64 (kind) 7m55s
e2e web live / amd64 (kind) 7m27s
build e2e images (arm64) 6m37s
web 6m17s

e2e buckets run

multicluster, upgrade

@ValgulNecron Claude

ValgulNecron commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

build e2e images (amd64) on run 38603914028 was cancelled when it hit its 15-minute timeout-minutes (17:07:59 to 17:23:42) while building images. This PR changes one type annotation in web/src/lib/fleet.ts and doesn't touch any image build, so the timeout isn't caused by this diff. The arm64 image build finished in 6m37s and every job that ran passed. I'm re-running the failed job once.

Generated by Claude Code

@ValgulNecron
ValgulNecron marked this pull request as ready for review October 14, 2026 17:47
@ValgulNecron
ValgulNecron merged commit ec0f332 into master Oct 14, 2026
68 of 69 checks passed
ValgulNecron pushed a commit that referenced this pull request Oct 14, 2026
@claude
chore: merge master into claude/project-thread-awjqv0
3b84f01 
Brings in PRs #630, #690, #691 and #696. Conflicts resolved:
- api/internal/notify/format.go: master's remote-cluster headline is
  kept through a new notify.title.cluster message, so
  "[prod] server unhealthy: remote-1/games/mc" is unchanged in English;
  app.json regenerated with make i18n-sync.
- web/src/lib/endpoints.ts: master's cluster parameter on Modules,
  and Modules.locales takes the same parameter.
- web/src/components/ui/NotificationsPanel.tsx: both the formatter ref
  effect and master's enabled guard.
- docs/architecture.md: master's standalone-panel paragraph, then the
  Internationalization section.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron mentioned this pull request Oct 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ValgulNecron ValgulNecron

Labels

area: web React dashboard type: fix Bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ValgulNecron @claude