Repository navigation
fix(progress): count each ESRI feature in one cell, not two - #7
Merged
Merged
Conversation
The mapping step reports a cell for every feature it writes. The ESRI download step reported the same features again, so fetch-stage maps showed twice the real count on ESRI sources. The download step now reports only the features it skips, which never reach the mapping step. Claude-Session: https://claude.ai/code/session_014jDQfgEffxXkhD6rWYjpJr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESRI sources reported every feature twice in the progress cells, so ChopChop's fetch-stage map showed twice the real count. The download step (
openaddr/cache.py) reported a cell for each kept feature, and the mapping step (openaddr/conform.py) reported the same feature again.The download step now reports only skipped features. Those never reach the mapping step, so each feature lands in exactly one cell.
Found in an end-to-end run of ChopChop PR #202 on real sources. On every ESRI fetch stage the cell total was exactly 2× the feature count (Kandiyohi addresses 44,956 for 22,478 features). HTTP sources and the Go stages were exact.
Testing
python3 test.py) in the published image with this branch mounted: 138 tests, OK.test_esri_download_reports_progressnow asserts the download line carries no cells.https://claude.ai/code/session_014jDQfgEffxXkhD6rWYjpJr