Skip to content

fix(progress): count each ESRI feature in one cell, not two #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiniCodeMonkey merged 1 commit into from
Oct 9, 2026
Merged

fix(progress): count each ESRI feature in one cell, not two #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions openaddr/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,6 @@ def download(self, source_urls, workdir, source_config):
writer.writerow({fn: row.get(fn) for fn in field_names})
size += 1
progress.reporter.advance()
if point is not None:
progress.reporter.cell(point.x, point.y, 'ok')
except TypeError:
_L.debug("Skipping a geometry", exc_info=True)
progress.reporter.count('skipped')
Expand Down
2 changes: 1 addition & 1 deletion openaddr/tests/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ def test_esri_download_reports_progress(self):
self.assertEqual(len(lines), 2)
self.assertEqual((lines[0]['phase'], lines[0]['done'], lines[0]['total']), ('Downloading from ArcGIS', 0, 5))
self.assertEqual((lines[1]['done'], lines[1]['total']), (5, 5))
self.assertEqual(sum(counts[0] for counts in lines[1]['cells'].values()), 5)
self.assertNotIn('cells', lines[1])

def test_skip_esri_features_with_nan_geometry(self):
""" ESRI Caching Will Skip Features Whose Geometry Is The String "NaN" """
Expand Down
Loading