Repository navigation
ci: run TechAPI automation as reusable workflows without personal tokens - #126
Merged
Merged
Conversation
Workflows used the maintainer's personal access token (TECHAPI_TOKEN) and the TechEngineBot account token to push, open PRs, comment and file issues on TechAPI, so automation ran under real accounts. Move every TechAPI-touching job behind workflow_call so TechAPI calls it and the caller's GITHUB_TOKEN does the writing as github-actions[bot]. - techapi-pr-validation-comment, techapi-verify-comment, weekly-refresh, weekly-ingest and verify-network become workflow_call-only and check out TechEngine explicitly (a bare checkout fetches the caller). - validate-data checks out TechEngine explicitly for the same reason. - coverage-report runs weekly and updates only this repo's issue. - Remove bump-techapi, notify-techapi, verify-status and dump-refresh; TechAPI's dump-develop takes over the status aggregate and full dump refresh. - Record the decision as ADR-017 and update SPEC 16.1, README and DEVELOPMENT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Workflows that touched TechAPI used a personal access token (
TECHAPI_TOKEN) and the TechEngineBot account token to push, open PRs, comment and file issues, so automation ran under real accounts. This moves every TechAPI-touching job behindworkflow_call: TechAPI calls it, and the caller'sGITHUB_TOKENdoes the writing asgithub-actions[bot]. Recorded as ADR-017.How
techapi-pr-validation-comment,techapi-verify-comment,weekly-refresh,weekly-ingestandverify-networkare nowworkflow_call-only. They check out TechEngine explicitly, because a bare checkout in a called workflow fetches the caller.validate-datachecks out TechEngine explicitly for the same reason.coverage-reportruns weekly and updates only this repo's issue.bump-techapi,notify-techapi,verify-statusanddump-refresh. TechAPI'sdump-developtakes over the status aggregate and the full dump refresh.final-review.yml: one comment per PR, posted when a maintainer asks for it with/final-review.Companion PR: GetTechAPI/TechAPI
ci/actions-rebuild. Merge this one first, since TechAPI calls these workflows@main.Testing
actionlint1.7.7 passes on every workflow here, and on TechAPI's callers with theiruses:rewritten to point at these files locally. That run checks inputs, types and permissions.Checklist
app/verify)ruff checkandpytestpass locally (not run; Python changes are a comment and a printed string)python -m app.validate(n/a)