Skip to content

Patch Vite and Vitest while preserving test and browser contracts - #206

Merged
mvalancy merged 4 commits into
devfrom
fix/toolchain-security-20261027
Oct 28, 2026
Merged

mvalancy merged 4 commits into
devfrom
fix/toolchain-security-20261027

Conversation

@mvalancy

Copy link
Copy Markdown
Member

Updates the compatible build/test toolchain to Vite 7.3.7, React plugin 5.2.0 and Vitest/V8 coverage 4.1.12. Removes vulnerable Tinypool/Vite-node paths while preserving supported Node versions, browser build targets, source-only discovery, unimported-source coverage, MCP worker isolation and strict test evidence.

Refs #185. Stacked on OAuth PR #202 (d83fd9a); this does not close runtime-image packaging, Turbo or Mermaid work.

The migration exposed real behavior changes: compiled tests were discovered twice, nested runner types broke matcher augmentation, expensive fixture queries/proof solving hit existing deadlines, and intentional-skip counters changed. These are corrected without adding retries or extending test deadlines. Earlier failures remain recorded in the migration evidence.

Validation at source a5b2593605b7b53bc8da8f13a9dd4da862a67bd9:

  • Pinned clean install, four-package build, typecheck and lint passed on the migration runtime; reporter-only follow-up passed 192/192 harness cases.
  • Node 22 coverage: core 41, server 211, web 353, MCP 110; 26 database opt-ins remain explicit skips. Owned real Neo4j MCP run: 136/136 in CI CPU-monitor mode.
  • Node 24 core/server/MCP coverage and current full web coverage (353) passed. Final supported-Node coverage matrix is required before integration.
  • Exactly 75 tracked source test files discovered with and without compiled output; coverage retains zero-hit source, including offline-shell.ts.
  • Real unified web adapter: 353/353; actual installed-runner pass/failure/required-skip/optional-skip outcomes verified. Required skips still fail.
  • New required browser contract proves React HMR state preservation, HTTP/WebSocket proxy routing, secret-file denial and compiled offline loading/cache exclusions.
  • Old dependency guard: 10 failures and one compatibility control pass; current dependency guard passes all 11. Fresh audit: zero production findings, three remaining full-inventory entries (separately scoped).

Independent exact-head review requested. Final CI, application/browser composition checks and subsequent post-merge CI remain required. This is not runtime-image, hosted-backend, Windows-execution or deployment clearance.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy

Copy link
Copy Markdown
Member Author

Imported reviewed LOD correction #207 without changing this feature's own implementation. The composition adds exactly four reviewed paths (renderer effect, regression, lesson and index); independent review verified complete tree/blob unions, parents and unchanged feature code. Source #207 passes LOD desktop/phone2/2, web346/346, harness175/175, smoke6/6, build/types/lint. Refreshed exact-head CI is active; earlier failures/cancelled superseded runs are retained and are not passes. The CSS acceptance failure is addressed by the isolated transition-ownership fix, not by retries or relaxed assertions.

@mvalancy

Copy link
Copy Markdown
Member Author

Final correction composition is now 6a99a97cbc65312843be7f69ed5d6a7c84e4e0d1. Independent review verified the complete six-path import from reviewed LOD/camera-readiness head 7cbf292: source renderer, both browser regressions and lessons match byte-for-byte; feature-specific code and dependencies remain unchanged. The symptom index retains every previous row and adds the motion lesson. No instruction or authority changes.

The combined local motion suite passes 3/3 in 2.1 minutes with zero retries; combined LOD validation and fresh exact-head CI remain pending. Previous green heads do not establish this composition's final acceptance. Earlier LOD/rotation failures and insufficient title-geometry evidence remain retained. Integration follows #207 → #210 → #199 → #195 → #197 → #202 → #206 → #211, with native dev merge verification and post-merge CI before issue closeout. Independent agent review is not a GitHub non-author approval.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy
mvalancy changed the base branch from fix/oauth-verified-identity-20261027 to dev October 28, 2026 00:14
@mvalancy
mvalancy marked this pull request as ready for review October 28, 2026 00:14
@mvalancy

Copy link
Copy Markdown
Member Author

Final native dev-only integration evidence for 6a99a97cbc65312843be7f69ed5d6a7c84e4e0d1: compatible Vite/Vitest upgrade with strict discovery, coverage, reporter and installed dev-consumer contracts. Independent exact-head implementation/composition reviews found no remaining findings. The reviewed camera corrections are included; feature-specific code is unchanged from its reviewed source.

CI40602595002 and Comprehensive40602595043 passed every applicable job. Downloaded strict artifacts verify smoke6, new-user42, LOD2, routes7, mobile27 and performance3, all with zero failed/warned/skipped cases, evidence errors, timeouts or nonzero executions. Effects, showcase, supported-Node coverage, installer and real-Neo4j gates also passed. The main/nightly-only production job is inapplicable to this dev PR.

The live base and complete merge result will be checked against the preceding reviewed stack tree immediately around the native operation. Expected resulting tree: bda7a5a6e2f4ab70dfdd1a30e641bf6afa366b37. Retargeting a stacked PR to an equivalent dev tree changes no feature content. Earlier failures remain retained; no retry is substituted for a fix.

This uses the owner's standing dev administrator authority and does not claim a GitHub non-author approval. Issue closeout waits for successful validation of the integrated dev head; intermediate post-merge runs may be superseded by later reviewed stack integration and are not counted as passes. Main, release, deployment and protection remain unchanged.

@mvalancy
mvalancy merged commit cd9b441 into dev Oct 28, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant