Repository navigation
Unify item wire paths, arrows and draggable labels - #221
Conversation
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
|
Latest pushed checkpoint Owner reprioritized GyroPup server reachability/sound during this work. Renderer worktree is clean and fully pushed; resume from this source, inspect latest CI and obtain corrected-source independent review before any dev merge. Earlier9931 and d9 runs are superseded, not acceptance of this checkpoint. Group PR216 and completed issues215/218/219 remain accepted on dev007148f. |
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
mvalancy
left a comment
There was a problem hiding this comment.
Independent agent review: no remaining blocking findings for the consumer-geometry foundation at 6ac0f4836e5a20aa7834a722bd03a48b830b1b54.
I reviewed the complete 14-file diff from live dev 007148f1a526b8ef028222a429b346a67e5c3c2c, including runtime consumers, geometry, diagnostics, fixture ownership, CI and lessons. Prior hidden-measurement, line-only diagnostic, camera-readiness and paint-oracle findings are corrected. The amended sizing test explicitly injects/counts the empty-measurement branch; it does not assume native Chromium always measures zero. Earlier failures and controlled negatives remain retained.
Composition: live dev and PR refs were checked again for this review. Tested merge 10b51a766067fc453be485b5cbf6fe3b98b4bb8f has parents 007148f1a526b8ef028222a429b346a67e5c3c2c and 6ac0f4836e5a20aa7834a722bd03a48b830b1b54. Complete tree 873a61947954b9e371d4ef3c849440ab4c71eb67 equals the source tree and independent merge-tree. Checkout is clean.
Verified evidence:
- CI 40648634230 and Comprehensive 40648634238 passed. Inspected actual job/step results: quality/build/security, all unit packages, Node22.18/24 matrices, installer/Compose, real-Neo4j MCP and three runtime images. The skipped main/nightly production-stack job is outside this dev PR and is not production acceptance.
- Independently downloaded all six final artifacts and verified published SHA-256 digests. Browser artifact: ten unified reports, 104 passed, zero failures/warnings/skips/evidence errors, exit0/no timeouts. Counts: static4, smoke6, item-wires2, new-user42, semantic2, nested2, layout9, routes7, mobile27, performance3. All record clean unchanged merge
10b51a7, fingerprint5ae77483d3d3eb610560c125d1658b05dd8919e77536f3cb437d5a03c953b479; all27 referenced attachments exist. - Viewed final item-wire PNG/JSON before/after dragging and hidden sizing, both301-node desktop/phone captures, a phone focused-bus capture and representative showcase. Paint/hitboxes, API-directed endpoints and arrows agree; hidden-sizing evidence records one injected empty measurement, width/background106 and deferred display. The showcase's zero-connection graph is not wire acceptance.
- Three runtime contract logs pass initial/replacement API, CAPTCHA, compiled MCP, independent database readback, native SQLite and replacement recovery. Job logs confirm197 harness,9 schematic geometry,427 web cases and3 living-effects cases (51.5s).
- Independently ran exact-source pure geometry in an isolated scratch directory, existing dependencies, Node22.18, one worker: 11 passed,203ms total/9ms bodies. No local browser, database service, install, build or image suite started. Evidence retained at
/tmp/graphdone-resolution-20261027/pr221-independent-final-6ac0f48, includingreview-proof.json.
This is independent agent evidence submitted as COMMENT, not GitHub non-author approval. No source edits or merge. The connector could not create the review (403 resource inaccessible by integration); this submission uses the already configured CLI under the same confirmed mvalancy account, without credential or permission changes.
Refresh the PR description to final evidence, recheck live base immediately before exact-head dev integration, and inspect post-merge branch CI before integration closeout. Paths remain straight: this does not complete obstacle routing, clipping/overlap/tiny-text/card-density work, large-graph capacity, hosted parity or release/deployment. Keep #220 and #222 open.
|
PR #221 is merged by the authorized native administrative dev operation. Actual dev Independent COMMENT review found no foundation blockers; this is not a non-author GitHub approval. Final source CI40648634230 and Comprehensive40648634238 passed; earlier failures remain recorded. Post-dev CI40705480289 is running; Comprehensive40705480276 passed. Closeout awaits the actual post-dev artifacts. #220 stays open for its unfinished obstacle routing/buses; the current readable-symbol slice remains one draft #223 under #222. Core now has two open PRs: this active visual slice and the explicitly parked main-promotion #191. |
|
Independent post-dev closeout audit for the PR #221 foundation checkpoint is clear.
Evidence retained at |
The detailed renderer used separate straight-line assumptions for wires, hitboxes, arrows and labels. This change gives them one route geometry, preserving the clickable path, target arrow and draggable label as routing evolves.
Final source
6ac0f4836e5a20aa7834a722bd03a48b830b1b54; live dev base007148f1a526b8ef028222a429b346a67e5c3c2c. Tested merge10b51a766067fc453be485b5cbf6fe3b98b4bb8f; complete tree873a61947954b9e371d4ef3c849440ab4c71eb67equals the source and independently recomputed composition.Validation:
5ae77483…; all 27 referenced attachments present. Runtime logs and living-effects evidence checked independently. Exact-source review is posted separately on this PR; it is agent review, not a non-author GitHub approval.Item routes remain straight border-to-border paths. Full obstacle routing and buses stay in #220; card/label cleanliness and thousands-of-item zoom evidence continue in #222 / #223. This foundation does not claim full LOD completion, hosted parity or release readiness. CodeGraph ideas only; no shared library.
Continues #220 and #193. Neither is closed by this foundation. Administrative integration is dev-only under the repository's standing policy, followed by exact parent/tree verification and final dev CI.