Skip to content

Unify item wire paths, arrows and draggable labels - #221

Merged
mvalancy merged 6 commits into
devfrom
feat/item-schematic-wiring-20261028
Oct 28, 2026
Merged

mvalancy merged 6 commits into
devfrom
feat/item-schematic-wiring-20261028

Conversation

@mvalancy

@mvalancy mvalancy commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

The detailed renderer used separate straight-line assumptions for wires, hitboxes, arrows and labels. This change gives them one route geometry, preserving the clickable path, target arrow and draggable label as routing evolves.

  • One polyline supplies visible/clickable paths and the final-segment arrow. Labels fit clear segments, remain upright and drag along their displayed offset without jumping away from the pointer.
  • Hidden labels retain conservative dimensions until measurement is valid. Opposite-direction relationships use separate canonical lanes. Culling composes with route/label admission.
  • Wire and label clicks open the same original relationship editor. Diagnostics sample actual paths. Original IDs, directions and saved coordinates remain canonical.
  • Eleven pure geometry cases and two blocking browser cases cover paint, hitboxes, arrows, actual pointer dragging/editing, hidden sizing and unchanged source data. Owned fixtures use strict edge-first cleanup.

Final source 6ac0f4836e5a20aa7834a722bd03a48b830b1b54; live dev base 007148f1a526b8ef028222a429b346a67e5c3c2c. Tested merge 10b51a766067fc453be485b5cbf6fe3b98b4bb8f; complete tree 873a61947954b9e371d4ef3c849440ab4c71eb67 equals the source and independently recomputed composition.

Validation:

  • CI40648634230 and Comprehensive40648634238 passed: clean install, build, lint/types, all package tests on supported Node versions, production audit, real Neo4j MCP, three runtime images, installer/deploy configuration and strict browser gates.
  • Final artifact audit: ten unified reports, 104 passes, zero failures/warnings/skips/evidence errors, unchanged clean fingerprint 5ae77483…; all 27 referenced attachments present. Runtime logs and living-effects evidence checked independently. Exact-source review is posted separately on this PR; it is agent review, not a non-author GitHub approval.
  • Owned local headed checks: two item-wire cases passed in21.9s, one worker, zero retries. Deliberately removing the valid-measurement guard failed with cached width36 versus the required104, then restoring the guard passed.
  • Earlier93fe CI40646515194 failed because the hidden-measurement test assumed that hidden SVG text always measures empty; Chromium instead supplied a valid width94.90625. Commit6ac explicitly exercises empty hidden measurement and verifies that branch. Cancelled earlier runs are not acceptance. The canonical lesson retains these failures and limits.

Item routes remain straight border-to-border paths. Full obstacle routing and buses stay in #220; card/label cleanliness and thousands-of-item zoom evidence continue in #222 / #223. This foundation does not claim full LOD completion, hosted parity or release readiness. CodeGraph ideas only; no shared library.

Continues #220 and #193. Neither is closed by this foundation. Administrative integration is dev-only under the repository's standing policy, followed by exact parent/tree verification and final dev CI.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy

Copy link
Copy Markdown
Member Author

Latest pushed checkpoint 93fe6d2 on feat/item-schematic-wiring-20261028 addresses both independent browser-oracle findings: wait for cameraReady as well as physics; require ancestor visibility and actual paint, with scoped invisible-wire/arrow negatives. Also checks original directed endpoints and editor relationship/type. Scoped typecheck/discovery pass; browser execution remains pending. PR221 stays draft and #220 stays open. Runtime geometry remains straight.

Owner reprioritized GyroPup server reachability/sound during this work. Renderer worktree is clean and fully pushed; resume from this source, inspect latest CI and obtain corrected-source independent review before any dev merge. Earlier9931 and d9 runs are superseded, not acceptance of this checkpoint. Group PR216 and completed issues215/218/219 remain accepted on dev007148f.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 22.18.0 & 24.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy mvalancy left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent agent review: no remaining blocking findings for the consumer-geometry foundation at 6ac0f4836e5a20aa7834a722bd03a48b830b1b54.

I reviewed the complete 14-file diff from live dev 007148f1a526b8ef028222a429b346a67e5c3c2c, including runtime consumers, geometry, diagnostics, fixture ownership, CI and lessons. Prior hidden-measurement, line-only diagnostic, camera-readiness and paint-oracle findings are corrected. The amended sizing test explicitly injects/counts the empty-measurement branch; it does not assume native Chromium always measures zero. Earlier failures and controlled negatives remain retained.

Composition: live dev and PR refs were checked again for this review. Tested merge 10b51a766067fc453be485b5cbf6fe3b98b4bb8f has parents 007148f1a526b8ef028222a429b346a67e5c3c2c and 6ac0f4836e5a20aa7834a722bd03a48b830b1b54. Complete tree 873a61947954b9e371d4ef3c849440ab4c71eb67 equals the source tree and independent merge-tree. Checkout is clean.

Verified evidence:

  • CI 40648634230 and Comprehensive 40648634238 passed. Inspected actual job/step results: quality/build/security, all unit packages, Node22.18/24 matrices, installer/Compose, real-Neo4j MCP and three runtime images. The skipped main/nightly production-stack job is outside this dev PR and is not production acceptance.
  • Independently downloaded all six final artifacts and verified published SHA-256 digests. Browser artifact: ten unified reports, 104 passed, zero failures/warnings/skips/evidence errors, exit0/no timeouts. Counts: static4, smoke6, item-wires2, new-user42, semantic2, nested2, layout9, routes7, mobile27, performance3. All record clean unchanged merge 10b51a7, fingerprint 5ae77483d3d3eb610560c125d1658b05dd8919e77536f3cb437d5a03c953b479; all27 referenced attachments exist.
  • Viewed final item-wire PNG/JSON before/after dragging and hidden sizing, both301-node desktop/phone captures, a phone focused-bus capture and representative showcase. Paint/hitboxes, API-directed endpoints and arrows agree; hidden-sizing evidence records one injected empty measurement, width/background106 and deferred display. The showcase's zero-connection graph is not wire acceptance.
  • Three runtime contract logs pass initial/replacement API, CAPTCHA, compiled MCP, independent database readback, native SQLite and replacement recovery. Job logs confirm197 harness,9 schematic geometry,427 web cases and3 living-effects cases (51.5s).
  • Independently ran exact-source pure geometry in an isolated scratch directory, existing dependencies, Node22.18, one worker: 11 passed,203ms total/9ms bodies. No local browser, database service, install, build or image suite started. Evidence retained at /tmp/graphdone-resolution-20261027/pr221-independent-final-6ac0f48, including review-proof.json.

This is independent agent evidence submitted as COMMENT, not GitHub non-author approval. No source edits or merge. The connector could not create the review (403 resource inaccessible by integration); this submission uses the already configured CLI under the same confirmed mvalancy account, without credential or permission changes.

Refresh the PR description to final evidence, recheck live base immediately before exact-head dev integration, and inspect post-merge branch CI before integration closeout. Paths remain straight: this does not complete obstacle routing, clipping/overlap/tiny-text/card-density work, large-graph capacity, hosted parity or release/deployment. Keep #220 and #222 open.

@mvalancy
mvalancy marked this pull request as ready for review October 28, 2026 14:23
@mvalancy
mvalancy merged commit 058aaa7 into dev Oct 28, 2026
19 checks passed
@mvalancy

Copy link
Copy Markdown
Member Author

PR #221 is merged by the authorized native administrative dev operation. Actual dev 058aaa70befa17a45b5a6b864c1c674ea8a173c1 has parents 007148f1a526b8ef028222a429b346a67e5c3c2c and 6ac0f4836e5a20aa7834a722bd03a48b830b1b54; its complete tree 873a61947954b9e371d4ef3c849440ab4c71eb67 exactly matches the reviewed/tested composition.

Independent COMMENT review found no foundation blockers; this is not a non-author GitHub approval. Final source CI40648634230 and Comprehensive40648634238 passed; earlier failures remain recorded.

Post-dev CI40705480289 is running; Comprehensive40705480276 passed. Closeout awaits the actual post-dev artifacts. #220 stays open for its unfinished obstacle routing/buses; the current readable-symbol slice remains one draft #223 under #222. Core now has two open PRs: this active visual slice and the explicitly parked main-promotion #191.

@mvalancy

Copy link
Copy Markdown
Member Author

Independent post-dev closeout audit for the PR #221 foundation checkpoint is clear.

  • Verified live dev 058aaa70befa17a45b5a6b864c1c674ea8a173c1: parents 007148f1a526b8ef028222a429b346a67e5c3c2c and reviewed source 6ac0f4836e5a20aa7834a722bd03a48b830b1b54; complete tree 873a61947954b9e371d4ef3c849440ab4c71eb67 is identical to that reviewed source.
  • Post-dev CI and Comprehensive tests both succeeded as first-attempt push runs on that exact dev SHA. Applicable jobs/steps passed. The existing main/nightly production-stack job is outside this dev run and is not credited as executed.
  • Independently downloaded all six retained artifacts and verified their published SHA-256 digests. Ten actual unified reports contain 104 passed cases (4 schematic, 6 smoke, 2 item-wire, 42 new-user, 2 semantic LOD, 2 nested LOD, 9 durable recovery, 7 navigation, 27 mobile, 3 performance), zero failures/warnings/skips/timeouts/evidence errors, and exit 0. Every report records the same clean unchanged SHA and fingerprint 47114877b84a1e83feea86f70fac3e3ef567c4b303e4d1e7b7bb675ffbfbf658; all 27 referenced attachments exist. Inspected the three actual item-wire PNGs and their geometry/hidden-measurement records.
  • Actual logs confirm 197 runner/harness tests, 9 schematic geometry cases, 3 toolchain contracts and 3 living-effects browser cases (52.8s). Both Node 22.18 and Node 24 runs passed 789 unit tests with the existing 26 explicitly gated database skips; the separate real-Neo4j contract passed.
  • All three actual runtime-image contracts passed initial and replacement-container API/CAPTCHA/compiled MCP/independent Neo4j readback, native SQLite and volume recovery. Each immutable image ID matches its contract. Retained scans show no npm findings; the previously disclosed self-host 162 OS findings (43 high, 58 medium, 60 low, 1 unknown) remain a limitation, not security clearance.

Evidence retained at /tmp/graphdone-resolution-20261027/pr221-independent-postdev-058aaa7, including review-proof.json, the artifact manifest and all six verified archives/extractions. No local browser, service, build, source change or merge was performed for this audit. This closes the foundation validation checkpoint only: full item routing in #220 and the readability/scalability work in #222 / #223 remain open. Independent agent audit, not a non-author GitHub approval or release/deployment clearance.

@mvalancy
mvalancy deleted the feat/item-schematic-wiring-20261028 branch October 28, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant