[cartercanedy]

Closes #355

Summary

• move_into_raw now calls move_from_raw_parts on the destination array, which properly cleans up the array that's going to be clobbered
• reworks the internal-only from_iter implementation into an internal-only trait that enables cleaner collection of iterators into ua::Array and updates existing callsites
  • note: I think that this private trait + impl for ua::Array should eventually become a public implementation of the FromIterator trait, relying on Iterator::size_hint to perform optimistic preallocations while remaining sound

[sgoll]

Thank you for your pull request 🎉

I have only a few minor remarks, see below. And do you think it would be possible to add a test case that reproduces the memory leak—so that it fails without the fix and does not fail anymore now?¹

Footnotes

1. I'm not sure it can be done easily, because it would involve showing that a destructor is not run, which with Rust code would be relatively easy (writing a sentinel value in impl Drop), but not so with the foreign types we are dealing with here. But if anything came to mind… 😇 ↩

[cartercanedy]

I have only a few minor remarks, see below. And do you think it would be possible to add a test case that reproduces the memory leak—so that it fails without the fix and does not fail anymore now?

See #358, it's establishing the testing infrastructure to enable ASAN in CI, which actually found another leak.

Also, I added a test that sits behind --cfg asan and invokes ua::Array::move_into_raw, which would've failed before this patch, that's the best solution that I could think of.

[sgoll]

@cartercanedy Thank you! Just so you know, @uklotzde and I are currently attending EuroRust, so it'll probably take until next week for us to review your PRs.

[uklotzde]

Please add a changelog entry.

[Copilot]

🟡 Changes recommended

The leak probe does not reclaim the transferred raw allocation and will report a leak.

1 open issue

• Test leaks allocation after move_into_raw ownership transfer · New

What changed in this PR

Fixes an ownership leak in ua::Array::move_into_raw and updates internal iterator-based array construction.

Changes:

• Cleans up existing destination arrays before replacement.
• Replaces internal from_iter usage with collect_ua_array.
• Adds an ASAN leak probe and documentation updates.

File	Summary
src/​ua/​data_types/​node_attributes/​variable_attributes.rs	Updates array construction.
src/​ua/​data_types/​delete_subscriptions_request.rs	Updates array construction.
src/​ua/​data_types/​delete_monitored_items_request.rs	Updates array construction.
src/​ua/​data_types/​content_filter_element.rs	Updates array construction.
src/​ua/​data_types/​browse_next_request.rs	Updates array construction.
src/​ua/​data_types/​application_description.rs	Updates array construction.
src/​ua/​array.rs	Fixes ownership transfer and adds iterator support and leak testing.
src/​ua.rs	Re-exports the internal iterator helper.
src/​server.rs	Updates URL collection.
src/​lib.rs	Imports the iterator helper.
CHANGELOG.md	Documents the memory leak fix.
Cargo.toml	Registers the ASAN configuration.

_{Review effort: Lite}

[uklotzde]

@sgoll Ping.

[Copilot]

🟢 Approval recommended

The ownership change correctly cleans up replaced arrays, the iterator refactor preserves behavior, and no blocking issues remain.

No open issues 🎉

1 resolved since last review

• Test leaks allocation after move_into_raw ownership transfer

_{Review effort: Balanced}