Repository navigation
chore: run tests with ASAN in CI - #360
Open
cartercanedy wants to merge 4 commits into
Open
cartercanedy wants to merge 4 commits into
cartercanedy wants to merge 4 commits into
Conversation
cartercanedy
force-pushed
the
cc/asan
branch
3 times, most recently
from
October 14, 2026 12:37
09f43d2 to
103ce7c
Compare
uklotzde
marked this pull request as draft
October 17, 2026 10:02
Collaborator
|
Stacked PRs might not work (yet) with forked repositories. Marking this as Draft until #356 has been merged. |
cartercanedy
force-pushed
the
cc/asan
branch
2 times, most recently
from
October 20, 2026 12:10
a6c712d to
f7095e4
Compare
cartercanedy
force-pushed
the
cc/asan
branch
2 times, most recently
from
October 21, 2026 21:03
390a82f to
72ddf19
Compare
Collaborator
|
I tried to merge |
Collaborator
|
A first local test on Linux/Fedora failed. Update: Probably, because |
uklotzde
marked this pull request as draft
October 22, 2026 08:12
Collaborator
|
Run on CI succeeded: https://github.com/uklotzde/open62541/actions/runs/39746865588 |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The ASAN CI matrix can test an unintended target, and unpinned LLVM/nightly versions can cause required-job failures.
1 open issue
What changed in this PR
Adds AddressSanitizer test coverage for Rust tests and integrates native Linux/macOS ASAN jobs into CI.
Changes:
- Adds nightly ASAN test recipes with leak detection.
- Adds Linux and macOS ASAN CI matrix jobs.
- Updates the array ownership test to transfer raw allocation ownership safely.
| File | Description | Review findings |
|---|---|---|
src/ua/array.rs |
Updates the raw-array test to use move-based ownership transfer. | No unresolved findings. |
.justfile |
Defines reusable nightly ASAN test and command recipes. | No unresolved findings. |
.github/workflows/test.yaml |
Adds Linux/macOS ASAN jobs and macOS LLVM configuration. | The matrix target is not enforced by the test recipe; the LLVM/nightly pairing is not pinned or verified; and required-check configuration may still need repository-level updates. |
Review effort: Lite
| steps: | ||
| - name: Install Rust toolchain | ||
| # Sanitizers are only available on nightly Rust. | ||
| uses: dtolnay/rust-toolchain@nightly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #358
Summary
NOTE: stacked on top of #356, needs to be rebased before merge