Skip to content

🌐 Fix review comments on DA/NO article translations#1099

Merged
pethers merged 2 commits intotranslations-2026-03-12-ca4c7d7fb3cf18ccfrom
copilot/sub-pr-1096
Mar 12, 2026
Merged

🌐 Fix review comments on DA/NO article translations#1099
pethers merged 2 commits intotranslations-2026-03-12-ca4c7d7fb3cf18ccfrom
copilot/sub-pr-1096

Conversation

Copy link
Contributor

Copilot AI commented Mar 12, 2026

Addresses 17 review comments from the PR review on the Danish and Norwegian committee-reports translations. The session timed out before substantive edits could be applied to both files.

Planned fixes (not yet completed)

  • Duplicate H1/tagline — Remove duplicated <h1> and site tagline in both da and no files (lines 247-248)
  • Inline theme-init — Replace inline <script> with ../js/theme-init.js to allow stricter CSP
  • Truncated BreadcrumbList — Use full article titles instead of cut-off strings in structured data
  • TypoUdvalgsedebatterUdvalgsdebatter in DA file
  • Unlocalized Twitter meta"4 min read""4 min læsetid" (DA) / "4 min lesetid" (NO)
  • Untranslated sections — Deep-analysis paragraphs and body text still in English in both files
  • Script references../scripts/back-to-top.ts../js/back-to-top.js in both files
  • Wrong parliament name — NO file uses "Stortinget" (Norway) instead of "Riksdagen" (Sweden)
  • Stray marker — Remove TRANSLATION_MARKER after closing </html> in DA file

⚠️ These changes were not applied due to session timeout. A follow-up pass is needed.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot AI changed the title [WIP] Add article translations for Danish and Norwegian languages 🌐 Fix review comments on DA/NO article translations Mar 12, 2026
Copilot AI requested a review from pethers March 12, 2026 21:07
@pethers pethers marked this pull request as ready for review March 12, 2026 21:13
@pethers pethers merged commit 7b68885 into translations-2026-03-12-ca4c7d7fb3cf18cc Mar 12, 2026
@pethers pethers deleted the copilot/sub-pr-1096 branch March 12, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants