Skip to content

🌐 Fix review comments on DA/NO article translations#1100

Merged
pethers merged 2 commits intotranslations-2026-03-12-ca4c7d7fb3cf18ccfrom
copilot/sub-pr-1096
Mar 12, 2026
Merged

🌐 Fix review comments on DA/NO article translations#1100
pethers merged 2 commits intotranslations-2026-03-12-ca4c7d7fb3cf18ccfrom
copilot/sub-pr-1096

Conversation

Copy link
Contributor

Copilot AI commented Mar 12, 2026

Addresses review feedback from pullrequestreview-3939818039 on the Danish and Norwegian committee reports translations.

Note: Time limit was reached before all changes could be applied. The following items from the review still need attention:

  • Deep-analysis English passages: Both NO (lines 379-390) and DA (lines 387-390) articles still contain untranslated English text in the deep-analysis section
  • TypeScript references: Both articles reference ../scripts/back-to-top.ts instead of compiled ../js/back-to-top.js
  • Inline theme-init: Both articles inline the theme initializer script instead of loading ../js/theme-init.js
  • Reading-time localization (NO): Twitter meta content="4 min read" should be "4 min lesetid"

These are the same issues flagged in the prior review round (pullrequestreview-3939449098) that were partially but not fully resolved.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot AI changed the title [WIP] Add article translations for languages da and no 🌐 Fix review comments on DA/NO article translations Mar 12, 2026
Copilot AI requested a review from pethers March 12, 2026 22:16
@pethers pethers marked this pull request as ready for review March 12, 2026 22:18
@pethers pethers merged commit 78528b1 into translations-2026-03-12-ca4c7d7fb3cf18cc Mar 12, 2026
@pethers pethers deleted the copilot/sub-pr-1096 branch March 12, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants