ci(inferno): add test kit ref and backend inputs to the US Quality Core run - #1378
Merged
Merged
Conversation
…re run [skip ci] Two optional workflow_dispatch inputs: - test_kit_ref: run a branch, tag or SHA of the fork instead of the pinned TEST_KIT_REF, so a test kit fix can be tried in CI before the pin moves. - backends: a JSON array limiting the backend matrix, so a kit-only check does not have to occupy the runners for all seven legs. Both default to blank, which keeps the scheduled run and a plain manual run exactly as before.
…n failure [skip ci] Move TEST_KIT_REF from upstream v0.2.0 (41fc954) to 4b8bc2b, the fork's helios/ci-combined-fixes: v0.2.0 plus the two test kit fixes that are open upstream as pull requests 45 and 46 on inferno-framework/us-quality-core-test-kit. - Upstream PR 45 fixes the Simple Observation multiple-or status search, which was pinned to category=sdoh and failed against any conformant server. - Upstream PR 46 adds effectiveDateTime to the example ADI documentation Observation, so its patient + category + date search stops skipping. At this ref the suite is 580 pass on every backend (was 578 pass / 1 skip / 1 fail), so the OMITTED entry for the multiple-or test would suppress nothing. Remove it; the list is now empty.
…ombined-fixes ci(inferno): pin US Quality Core test kit to our fixes, drop the known failure
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two optional
workflow_dispatchinputs to the Inferno US Quality Core workflow, so a fix on our test kit fork can be tried in CI beforeTEST_KIT_REFmoves:test_kit_ref: a branch, tag or SHA inTEST_KIT_REPOto run instead of the pinned ref.backends: a JSON array limiting the backend matrix, e.g.["sqlite"], so a kit-only check does not occupy the runners for all seven legs.Both default to blank. The scheduled run and a plain manual run behave exactly as before: pinned ref, all seven backends.
Testing
Used from this branch to check two test kit fixes (HeliosSoftware/us-quality-core-test-kit#1 and #2):
test_kit_refbackends["sqlite"]I dispatched four runs at once, so four Inferno stacks (each with its own HL7 validator JVM) shared the Docker host. Three of the runs each lost one validation test to
Connection failed to validator, a different test each time. That is contention from running them concurrently, not something this change causes; run kit checks one at a time.