ci(inferno): pin US Quality Core test kit to our fixes, drop the known failure - #1385
Merged
smunini merged 1 commit intoSep 21, 2026
Conversation
…n failure [skip ci] Move TEST_KIT_REF from upstream v0.2.0 (41fc954) to 4b8bc2b, the fork's helios/ci-combined-fixes: v0.2.0 plus the two test kit fixes that are open upstream as pull requests 45 and 46 on inferno-framework/us-quality-core-test-kit. - Upstream PR 45 fixes the Simple Observation multiple-or status search, which was pinned to category=sdoh and failed against any conformant server. - Upstream PR 46 adds effectiveDateTime to the example ADI documentation Observation, so its patient + category + date search stops skipping. At this ref the suite is 580 pass on every backend (was 578 pass / 1 skip / 1 fail), so the OMITTED entry for the multiple-or test would suppress nothing. Remove it; the list is now empty.
Contributor
Author
Verified from this branchRun 35539859960, dispatched from
This replaces the "not yet run from this branch" note in the description. The other six backends were covered at the same test kit ref by run 35529459218. |
smunini
merged commit Sep 21, 2026
fd073c6
into
ci/us-quality-core-test-kit-ref-input
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
TEST_KIT_REFfrom upstreamv0.2.0(41fc954) to4b8bc2b, the head ofhelios/ci-combined-fixeson our fork. That isv0.2.0plus our two test kit fixes, both open upstream:category=sdohand failed against any conformant server.effectiveDateTimeto the example ADI documentation Observation, so itspatient + category + datesearch stops skipping.It also removes the
OMITTEDknown-failure entry for the multiple-or test. At the new ref that test passes, so the entry would suppress nothing; the list is now empty.Result
41fc954(before)4b8bc2b(after)Verified with the new ref passed through the
test_kit_refinput: 35529459218 (580 pass on six backends) and 35537188608 (580 pass on sqlite). In the first run the sqlite leg lost one validation test to a validator connection error, because I had four stacks on the Docker host at once; the second run is the clean sqlite result.Not yet run with the pin and the emptied
OMITTEDlist from this branch itself.Merge order
Stacked on #1378, since both change the
TEST_KIT_REFline. Merge #1378 first; this PR then retargets tomain.Follow-up
Move the pin back to an upstream release once one includes both fixes.