Skip to content

ci(inferno): pin US Quality Core test kit to our fixes, drop the known failure - #1385

Merged
smunini merged 1 commit into
ci/us-quality-core-test-kit-ref-inputfrom
ci/us-quality-core-pin-combined-fixes
Sep 21, 2026
Merged

smunini merged 1 commit into
ci/us-quality-core-test-kit-ref-inputfrom
ci/us-quality-core-pin-combined-fixes

Conversation

@smunini

@smunini smunini commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves TEST_KIT_REF from upstream v0.2.0 (41fc954) to 4b8bc2b, the head of helios/ci-combined-fixes on our fork. That is v0.2.0 plus our two test kit fixes, both open upstream:

It also removes the OMITTED known-failure entry for the multiple-or test. At the new ref that test passes, so the entry would suppress nothing; the list is now empty.

Result

Test kit ref Result per backend
41fc954 (before) 578 pass / 1 skip / 1 fail
4b8bc2b (after) 580 pass

Verified with the new ref passed through the test_kit_ref input: 35529459218 (580 pass on six backends) and 35537188608 (580 pass on sqlite). In the first run the sqlite leg lost one validation test to a validator connection error, because I had four stacks on the Docker host at once; the second run is the clean sqlite result.

Not yet run with the pin and the emptied OMITTED list from this branch itself.

Merge order

Stacked on #1378, since both change the TEST_KIT_REF line. Merge #1378 first; this PR then retargets to main.

Follow-up

Move the pin back to an upstream release once one includes both fixes.

…n failure [skip ci]

Move TEST_KIT_REF from upstream v0.2.0 (41fc954) to 4b8bc2b, the fork's
helios/ci-combined-fixes: v0.2.0 plus the two test kit fixes that are
open upstream as pull requests 45 and 46 on
inferno-framework/us-quality-core-test-kit.

- Upstream PR 45 fixes the Simple Observation multiple-or status search,
  which was pinned to category=sdoh and failed against any conformant
  server.
- Upstream PR 46 adds effectiveDateTime to the example ADI documentation
  Observation, so its patient + category + date search stops skipping.

At this ref the suite is 580 pass on every backend (was 578 pass /
1 skip / 1 fail), so the OMITTED entry for the multiple-or test would
suppress nothing. Remove it; the list is now empty.
@smunini

smunini commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

Verified from this branch

Run 35539859960, dispatched from ci/us-quality-core-pin-combined-fixes with backends=["sqlite"] and no test_kit_ref, so it used the new pin and the emptied omit list:

  • 580 total / 580 pass / 0 skip / 0 fail / 0 error
  • OMITTED_TESTS: [], and the omit-list audit step passes with an empty list ("nothing to prune")

This replaces the "not yet run from this branch" note in the description. The other six backends were covered at the same test kit ref by run 35529459218.

@smunini
smunini merged commit fd073c6 into ci/us-quality-core-test-kit-ref-input Sep 21, 2026
4 checks passed
@smunini
smunini deleted the ci/us-quality-core-pin-combined-fixes branch September 21, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant