Skip to content

ci(inferno): pin US Quality Core test kit to our fixes, drop the known failure #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smunini merged 1 commit into from
Sep 21, 2026
Merged

ci(inferno): pin US Quality Core test kit to our fixes, drop the known failure #1385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions .github/workflows/inferno-us-quality-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,12 @@ env:
# Pinned commit of our fork of inferno-framework/us-quality-core-test-kit.
# Provides both the Inferno stack and the fixture bundles loaded into HFS,
# so the suite and its data always move together. The fork carries no
# upstream tags, so pin by SHA: 41fc954 is upstream v0.2.0.
# upstream tags, so pin by SHA: 4b8bc2b is the fork's helios/ci-combined-fixes,
# upstream v0.2.0 (41fc954) plus our two fixes that are open upstream as
# inferno-framework/us-quality-core-test-kit#45 and #46. Move the pin back
# to an upstream release once one includes them.
TEST_KIT_REPO: HeliosSoftware/us-quality-core-test-kit
TEST_KIT_REF: ${{ inputs.test_kit_ref || '41fc954beee8e9046e7935a043e470966de9b890' }}
TEST_KIT_REF: ${{ inputs.test_kit_ref || '4b8bc2b814ee253058cf5820d35aab6e13d0640e' }}
# Remote Docker host (set via GitHub repository secrets or variables; leave unset for local Docker)
DOCKER_HOST: ${{ secrets.DOCKER_HOST }}
DOCKER_HOST_IP: ${{ secrets.DOCKER_HOST_IP }}
Expand Down Expand Up @@ -268,16 +271,10 @@ jobs:
# An entry here must suppress a *real* failure in the suite it is
# emitted for (#492); the "Report omissions that suppressed nothing"
# step below keeps the list honest. Baseline against the kit's own
# fixtures on sqlite: 578 pass / 1 skip / 1 fail, the fail being:

# simple_observation multiple-or status search: a test-kit/fixture
# gap, not an HFS one. The test searches category=sdoh (its first
# fixed category value) with every status OR'd, but takes the
# statuses it expects back (final, cancelled) from the patient's
# simple observations of *any* category. The kit's example bundle
# has no sdoh-category Observation at all, so the correct answer is
# an empty Bundle and the test fails against any conformant server.
OMITTED="\"${SUITE}-${SUITE}_fhir_api-${SUITE}_simple_observation-${SUITE}_simple_observation_patient_category_status_search_test\""
# fixtures at the pinned ref: 580 pass on every backend, so the list
# is empty. Upstream v0.2.0 was 578 pass / 1 skip / 1 fail; both were
# test-kit gaps, fixed in the pinned ref (see TEST_KIT_REF).
OMITTED=""

echo "OMITTED_TESTS=[${OMITTED}]" >> $GITHUB_ENV

Expand Down