Repository navigation
fix: pass release tag_name via env instead of interpolating it into run - #81
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
enriqueavindi
previously approved these changes
Oct 2, 2026
The quality gate introduced by the Go profile adoption (#65) fails on the pre-existing release.yml: SC2086 (unquoted $GITHUB_OUTPUT redirects) and SC2129 (individual redirects instead of a grouped one). Group the GITHUB_OUTPUT writes and quote the variable; the debug echo stays outside the group so it keeps printing to the job log. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ivanasabi <ivanasabi@ext.inditex.com>
|
enriqueavindi
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Security audit followed up on
release.yml: theCheck versionsjob interpolatedgithub.event.release.tag_namedirectly into arun:block four times. A crafted tag name could reach shell metacharacter evaluation in that job. Exploitation requires prior release/tag creation rights, so risk is low — fixed as hardening.Evidence
No behavior change: same four comparisons, same failure messages.
Merge Danger
Door: two-way (revert the commit)
Blast Radius: CI-only