Skip to content

fix: pass release tag_name via env instead of interpolating it into run #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enriqueavindi merged 4 commits into from
Oct 2, 2026
Merged

fix: pass release tag_name via env instead of interpolating it into run #81

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2763bb
fix: pass release tag_name via env instead of interpolating it into run
ivanasabi Oct 1, 2026
949b942
Merge branch 'main' into fix/shell-injection-release-tag
ivanasabi Oct 1, 2026
e357f4b
Merge branch 'main' into fix/shell-injection-release-tag
enriqueavindi Oct 2, 2026
e6032a4
fix: quote redirections in release version step to satisfy shellcheck
ivanasabi Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,41 +32,45 @@ jobs:
- name: 📝 Load Operator version
id: version
run: |
echo "version=$(make print-VERSION | cut -d'=' -f2)" >> $GITHUB_OUTPUT
echo "values_version=$(yq '.deployment.image.tag' chart/values.yaml)" >> $GITHUB_OUTPUT
echo "chart_version=$(yq '.appVersion' chart/Chart.yaml)" >> $GITHUB_OUTPUT
echo "catalog_version=$(yq '.spec.image' deploy/catalog_source.yaml | cut -d':' -f2)" >> $GITHUB_OUTPUT
echo $GITHUB_OUTPUT
{
echo "version=$(make print-VERSION | cut -d'=' -f2)"
echo "values_version=$(yq '.deployment.image.tag' chart/values.yaml)"
echo "chart_version=$(yq '.appVersion' chart/Chart.yaml)"
echo "catalog_version=$(yq '.spec.image' deploy/catalog_source.yaml | cut -d':' -f2)"
} >> "$GITHUB_OUTPUT"
echo "$GITHUB_OUTPUT"

check:
name: 🔎 Check versions
needs: release
runs-on: ubuntu-latest
steps:
- name: 🔎 Check versions
env:
RELEASE_TAG_NAME: ${{ github.event.release.tag_name }}
run: |
echo "version: ${{ needs.release.outputs.version }}"
echo "values_version: ${{ needs.release.outputs.values_version }}"
echo "chart_version: ${{ needs.release.outputs.chart_version }}"
echo "tag_name: ${{ github.event.release.tag_name }}"
echo "tag_name: $RELEASE_TAG_NAME"
echo "catalog_version: ${{ needs.release.outputs.catalog_version }}"

if [ "${{ github.event.release.tag_name }}" != "${{ needs.release.outputs.version }}" ]; then
if [ "$RELEASE_TAG_NAME" != "${{ needs.release.outputs.version }}" ]; then
echo "Version in Makefile does not match release tag"
exit 1
fi

if [ "${{ github.event.release.tag_name }}" != "${{ needs.release.outputs.values_version }}" ]; then
if [ "$RELEASE_TAG_NAME" != "${{ needs.release.outputs.values_version }}" ]; then
echo "Version in chart/values.yaml does not match release tag"
exit 1
fi

if [ "${{ github.event.release.tag_name }}" != "${{ needs.release.outputs.chart_version }}" ]; then
if [ "$RELEASE_TAG_NAME" != "${{ needs.release.outputs.chart_version }}" ]; then
echo "Version in chart/Chart.yaml does not match release tag"
exit 1
fi

if [ "${{ github.event.release.tag_name }}" != "${{ needs.release.outputs.catalog_version }}" ]; then
if [ "$RELEASE_TAG_NAME" != "${{ needs.release.outputs.catalog_version }}" ]; then
echo "Version in deploy/catalog_source.yaml does not match release tag"
exit 1
fi
Expand Down