Skip to content

refactor(stm, client, ci): add missing binaries in mithril-stm, improve verifications in Nightly Dispatcher - #3529

Merged
turmelclem merged 5 commits into
mainfrom
ctl/3507-fix-doc-rs-publication
Sep 9, 2026
Merged

refactor(stm, client, ci): add missing binaries in mithril-stm, improve verifications in Nightly Dispatcher#3529
turmelclem merged 5 commits into
mainfrom
ctl/3507-fix-doc-rs-publication

Conversation

@turmelclem

@turmelclem turmelclem commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Content

This PR includes :

  • fixing mithril-stm by adding missing binaries
  • Improve Nightly Dispatcher :
    • add a cargo publish in a dry run mode with verification
    • add a cargo clippy check job with minimal features

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

this PR closes #3507

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Test Results

     5 files  ±0     221 suites  ±0   1h 0m 42s ⏱️ + 2m 35s
 3 542 tests ±0   3 542 ✅ ±0  0 💤 ±0  0 ❌ ±0 
11 661 runs  ±0  11 661 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9843fbf. ± Comparison against base commit 471ada0.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The mithril-stm publish allowlist still excludes some referenced assets, and the new clippy scripts’ feature-selection logic does not fully match the stated “minimal/all-combinations” verification intent.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR addresses crates.io/doc.rs publication failures caused by missing packaged circuit key binaries in mithril-stm, and strengthens the nightly CI to catch packaging/feature-matrix issues earlier via cargo publish --dry-run verification and additional clippy workflows.

Changes:

  • Update mithril-stm packaging allowlist to include required embedded binary assets for doc.rs/crate builds.
  • Adjust feature wiring in mithril-client and mithril-stm to use dep:-style feature declarations for optional dependencies.
  • Extend the Nightly Dispatcher with dry-run publish verification and new clippy checks (single-crate sweep + feature-combination sweep).
File summaries
File Description
mithril-stm/Cargo.toml Expands include allowlist for publishing and adjusts rug-backend feature to dep:rug.
mithril-client/Cargo.toml Updates the fs feature to explicitly enable optional deps via dep:.
.github/workflows/scripts/clippy-check.sh Adds a script to run clippy across workspace crates.
.github/workflows/scripts/clippy-check-all-features.sh Adds a script to run clippy across feature combinations for each crate.
.github/workflows/nightly-dispatcher.yml Adds nightly jobs for publish dry-run verification and clippy checks.
.github/workflows/actions/publish-rust-crates/action.yml Adds dry_run_verify input to optionally run dry-run publish with verification.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 4
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread mithril-stm/Cargo.toml
Comment thread .github/workflows/scripts/clippy-check-all-features.sh Outdated
Comment thread .github/workflows/scripts/clippy-check-all-features.sh Outdated
Comment thread .github/workflows/scripts/clippy-check.sh
@turmelclem
turmelclem force-pushed the ctl/3507-fix-doc-rs-publication branch from 1ca63e2 to e7d4253 Compare September 9, 2026 09:48
@turmelclem
turmelclem marked this pull request as ready for review September 9, 2026 09:50
@turmelclem
turmelclem force-pushed the ctl/3507-fix-doc-rs-publication branch 3 times, most recently from 08db81c to 27fd9a4 Compare September 9, 2026 10:28
@jpraynaud
jpraynaud requested a lite review from Copilot September 9, 2026 10:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The dry_run_verify conditional in the composite publish action is likely to always inject --no-verify, preventing the intended verification step from running.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread .github/workflows/actions/publish-rust-crates/action.yml

@jpraynaud jpraynaud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread mithril-stm/Cargo.toml Outdated
@turmelclem
turmelclem force-pushed the ctl/3507-fix-doc-rs-publication branch from 27fd9a4 to bdd8bf3 Compare September 9, 2026 11:19
@turmelclem
turmelclem force-pushed the ctl/3507-fix-doc-rs-publication branch from bdd8bf3 to a62da89 Compare September 9, 2026 13:22
@turmelclem
turmelclem force-pushed the ctl/3507-fix-doc-rs-publication branch from a62da89 to 54e8b42 Compare September 9, 2026 14:30
@turmelclem
turmelclem force-pushed the ctl/3507-fix-doc-rs-publication branch from 54e8b42 to e23ca09 Compare September 9, 2026 14:33
@turmelclem
turmelclem force-pushed the ctl/3507-fix-doc-rs-publication branch from e23ca09 to c903562 Compare September 9, 2026 14:58
* mithril-client from `0.14.21` to `0.14.22`
* mithril-stm from `0.12.14` to `0.12.15`

@damrobi damrobi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@turmelclem
turmelclem merged commit b76d033 into main Sep 9, 2026
94 checks passed
@turmelclem
turmelclem deleted the ctl/3507-fix-doc-rs-publication branch September 9, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publication to doc.rs failed for distribution 2630

5 participants