refactor(stm, client, ci): add missing binaries in mithril-stm, improve verifications in Nightly Dispatcher - #3529
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The mithril-stm publish allowlist still excludes some referenced assets, and the new clippy scripts’ feature-selection logic does not fully match the stated “minimal/all-combinations” verification intent.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR addresses crates.io/doc.rs publication failures caused by missing packaged circuit key binaries in mithril-stm, and strengthens the nightly CI to catch packaging/feature-matrix issues earlier via cargo publish --dry-run verification and additional clippy workflows.
Changes:
- Update
mithril-stmpackaging allowlist to include required embedded binary assets for doc.rs/crate builds. - Adjust feature wiring in
mithril-clientandmithril-stmto usedep:-style feature declarations for optional dependencies. - Extend the Nightly Dispatcher with dry-run publish verification and new clippy checks (single-crate sweep + feature-combination sweep).
File summaries
| File | Description |
|---|---|
mithril-stm/Cargo.toml |
Expands include allowlist for publishing and adjusts rug-backend feature to dep:rug. |
mithril-client/Cargo.toml |
Updates the fs feature to explicitly enable optional deps via dep:. |
.github/workflows/scripts/clippy-check.sh |
Adds a script to run clippy across workspace crates. |
.github/workflows/scripts/clippy-check-all-features.sh |
Adds a script to run clippy across feature combinations for each crate. |
.github/workflows/nightly-dispatcher.yml |
Adds nightly jobs for publish dry-run verification and clippy checks. |
.github/workflows/actions/publish-rust-crates/action.yml |
Adds dry_run_verify input to optionally run dry-run publish with verification. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1ca63e2 to
e7d4253
Compare
08db81c to
27fd9a4
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The dry_run_verify conditional in the composite publish action is likely to always inject --no-verify, preventing the intended verification step from running.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
27fd9a4 to
bdd8bf3
Compare
bdd8bf3 to
a62da89
Compare
a62da89 to
54e8b42
Compare
…ish in dry run with verification
54e8b42 to
e23ca09
Compare
… workspace crates
…d exposing them has features of the crate
e23ca09 to
c903562
Compare
* mithril-client from `0.14.21` to `0.14.22` * mithril-stm from `0.12.14` to `0.12.15`
Content
This PR includes :
mithril-stmby adding missing binariescargo publishin a dry run mode with verificationcargo clippycheck job with minimal featuresPre-submit checklist
this PR closes #3507