refactor(stm, client, ci): add missing binaries in mithril-stm, improve verifications in Nightly Dispatcher

.github/workflows/actions/publish-rust-crates/action.yml

@@ -5,6 +5,10 @@ inputs:
   dry_run:
     description: Dry run will not publish to crates.io, just test it.
     required: true
+  dry_run_verify:
+    description: Build verification step when running the dry run publish.
+    required: false
+    default: "false"
   packages:
     description: comma separated list of rust crates to publish.
     required: true
@@ -74,7 +78,7 @@ runs:
       run: |
         echo "::group::Cargo publish packages (dry run)"
         echo "Packages to publish (dry-run): '${{ steps.check_versions.outputs.packages_to_deploy }}'"
-        cargo publish ${{ steps.check_versions.outputs.cargo_package_args }} --dry-run --no-verify --allow-dirty ${{ inputs.publish_args }}
+        cargo publish ${{ steps.check_versions.outputs.cargo_package_args }} --dry-run ${{ inputs.dry_run_verify == 'false' && '--no-verify' || '' }} --allow-dirty ${{ inputs.publish_args }}
         echo "::endgroup::"
 
     - name: Cargo package list

.github/workflows/nightly-dispatcher.yml

@@ -26,6 +26,41 @@ jobs:
   test-e2e:
     uses: ./.github/workflows/test-e2e.yml
 
+  publish-crate-dry-run-with-verification:
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v6
+
+      - name: Install stable toolchain
+        uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: stable
+
+      - name: Publish package to crates.io
+        uses: ./.github/workflows/actions/publish-rust-crates
+        with:
+          dry_run: "true"
+          dry_run_verify: "true"
+          publish_args: "--features rustls"
+          packages: mithril-stm, mithril-build-script, mithril-common, mithril-aggregator-client, mithril-aggregator-discovery, mithril-cardano-node-internal-database, mithril-client, mithril-merkle-tree
+
+  clippy-check-all-crates:
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v6
+
+      - name: Install stable toolchain
+        uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: stable
+
+      - name: Run clippy check on all crates
+        shell: bash
+        run: |
+          ./.github/workflows/scripts/clippy-check.sh
+
   notify-on-failure:
     uses: ./.github/workflows/test-notify-on-failure.yml
     needs:
@@ -35,6 +70,8 @@ jobs:
         test-client,
         test-rust,
         test-e2e,
+        publish-crate-dry-run-with-verification,
+        clippy-check-all-crates,
       ]
     if: failure()
     secrets: inherit

.github/workflows/scripts/clippy-check.sh

@@ -0,0 +1,35 @@
+#!/usr/bin/env bash
+set -eu -o pipefail
+
+if [[ "${TRACE-0}" == "1" ]]; then set -o xtrace; fi
+
+
+clippy_all_crates() {
+    local exit_code=0
+    mapfile -t members < <(
+    cargo metadata --no-deps --format-version 1 |
+        jq -r '.packages[].name'
+    )
+
+    for package_name in "${members[@]}"; do
+        additional_args=()
+        if [[ " mithril-client " == *" ${package_name} "* ]]; then
+            additional_args+=(--features rustls)
+        fi
+
+        if [[ " mithril-stm " == *" ${package_name} "* ]]; then
+            additional_args+=(--features "future_snark,rustls,benchmark-internals")
+        fi
+
+        echo -e " Running clippy for package: ${package_name}"
+        if ! cargo clippy --all-targets --package "${package_name}" "${additional_args[@]}" -- -D warnings; then
+            echo -e " Clippy check failed for package: ${package_name}"
+            exit_code=1
+        fi
+    done
+
+    return "$exit_code"
+}
+
+clippy_all_crates
+exit $?

mithril-client/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-client"
-version = "0.14.21"
+version = "0.14.22"
 description = "Mithril client library"
 authors = { workspace = true }
 edition = { workspace = true }
@@ -25,7 +25,7 @@ default = ["num-integer-backend", "enable-http-compression"]
 full = ["fs"]
 
 # Enable file system-related functionality for Cardano database downloads
-fs = ["flume", "tar", "tokio/rt", "zstd"]
+fs = ["dep:flume", "dep:tar", "tokio/rt", "dep:zstd"]
 unstable = []
 
 # These features are for support of dependent crates only.

mithril-common/Cargo.toml

@@ -51,7 +51,7 @@ fixed = "1.31.0"
 hex = { workspace = true }
 kes-summed-ed25519 = { version = "0.2.1", features = ["serde_enabled", "sk_clone_enabled"] }
 mithril-merkle-tree = { path = "../internal/mithril-merkle-tree", version = "0.1.4" }
-mithril-stm = { path = "../mithril-stm", version = "0.12.14", default-features = false }
+mithril-stm = { path = "../mithril-stm", version = "0.12.15", default-features = false }
 nom = "8.0.0"
 rand_chacha = { workspace = true }
 rand_core = { workspace = true }

mithril-stm/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-stm"
-version = "0.12.14"
+version = "0.12.15"
 edition = { workspace = true }
 authors = { workspace = true }
 homepage = { workspace = true }
@@ -15,6 +15,18 @@ include = [
     ".gitignore",
     "src/circuits/halo2/non_recursive_circuit_verification_key_for_production.bin",
     "src/circuits/halo2_ivc/recursive_circuit_verification_key_for_production.bin",
+    "src/circuits/halo2/tests/golden/assets/golden_non_recursive_verification_key.bin",
+    "src/circuits/halo2_ivc/tests/assets/golden_recursive_circuit_verification_key.bin",
+    "src/circuits/halo2_ivc/tests/assets/recursive_step_output_accumulator_bytes.bin",
+    "src/circuits/halo2_ivc/tests/assets/recursive_proof_accumulator_bytes.bin",
+    "src/circuits/halo2_ivc/tests/assets/recursive_chain_state.bin",
+    "src/circuits/halo2_ivc/tests/assets/verification_context.bin",
+    "src/circuits/halo2_ivc/tests/assets/recursive_step_output.bin",
+    "src/circuits/halo2_ivc/tests/assets/genesis_step_output.bin",
+    "src/circuits/halo2_ivc/tests/assets/same_epoch_step_output.bin",
+    "src/circuits/halo2_ivc/tests/assets/first_step_cert.bin",
+    "src/circuits/halo2_ivc/tests/assets/genesis_benchmark_fixture.bin",
+    "src/proof_system/halo2_snark/golden_vectors/*.txt"
 ]
 
 [package.metadata.docs.rs]
@@ -51,7 +63,7 @@ future_snark = [
 native-tls = ["reqwest?/native-tls"]
 rustls = ["reqwest?/rustls"]
 num-integer-backend = ["dep:num-bigint", "dep:num-integer", "dep:num-rational", "dep:num-traits"]
-rug-backend = ["rug/default"]
+rug-backend = ["dep:rug"]
 
 [dependencies]
 anyhow = { workspace = true }