fix: macOS x64 prebuilt binary contains arm64 architecture#446
Merged
fix: macOS x64 prebuilt binary contains arm64 architecture#446
Conversation
The universal build lipo extraction wrote both architectures to the same output file before packaging, so the arm64 slice overwrote the x86_64 one. Both tarballs ended up containing the arm64 binary. Fix by interleaving: extract each architecture and package it immediately before extracting the next. Fixes #445
…for cross arch The previous fix left the x86_64 binary in lib/binding/ after packaging, causing tests to fail on arm64 CI runners. Now we package the cross arch first (without testpackage since it can't be loaded), then the native arch last (with testpackage) so the correct binary remains for tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/ci/build.shwhere bothlipoextractions wrote to the same output file before either was packaged — the arm64 slice overwrote the x86_64 one, so both tarballs contained arm64 binariesTest plan
filethat each tarball contains the correct architectureFixes #445