Skip to content

fix: macOS x64 prebuilt binary contains arm64 architecture #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JCMais merged 2 commits into from
Apr 12, 2026
+17 −4
Merged

fix: macOS x64 prebuilt binary contains arm64 architecture #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
831b201
fix: macOS x64 prebuilt binary contains arm64 architecture
JCMais Apr 12, 2026
96399a3
fix: restore native arch binary after packaging and skip testpackage …
JCMais Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions scripts/ci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,11 +494,24 @@ if [[ "$MACOS_UNIVERSAL_BUILD" == "true" ]]; then
# play well with electron-builder which will try to lipo native add-ons
# for different architectures.
# --
lipo build/Release/node_libcurl.node -thin x86_64 -output lib/binding/node_libcurl.node
lipo build/Release/node_libcurl.node -thin arm64 -output lib/binding/node_libcurl.node
native_arch=$(uname -m)
if [ "$native_arch" == "x86_64" ]; then
cross_arch="arm64"
native_npm_arch="x64"
cross_npm_arch="arm64"
else
cross_arch="x86_64"
native_npm_arch="arm64"
cross_npm_arch="x64"
fi

# Package the cross-compiled architecture first (no testpackage - can't load it)
lipo build/Release/node_libcurl.node -thin $cross_arch -output lib/binding/node_libcurl.node
npm_config_target_arch=$cross_npm_arch pnpm pregyp package --verbose

npm_config_target_arch=arm64 pnpm pregyp package testpackage --verbose
npm_config_target_arch=x64 pnpm pregyp package testpackage --verbose
# Package the native architecture (with testpackage to verify it loads)
lipo build/Release/node_libcurl.node -thin $native_arch -output lib/binding/node_libcurl.node
npm_config_target_arch=$native_npm_arch pnpm pregyp package testpackage --verbose
else
pnpm pregyp package testpackage --verbose
fi
Expand Down
Loading