Repository navigation
Conversation
… missing On X11 (including Xvfb cloud agents) the ScreenCast portal often has no METADATA cursor mode, so editable-cursor takes used to write no sidecar. Sample the pointer via Electron/xdotool/xev during record, write the version-2 <video>.cursor.json next to the take, and add `openscreen cursor import` for an external CSV. export --auto-zoom then works with no extra step.
Stop the X11 sampler on discard, compact pause ranges into the fallback sidecar, start the sampler clock at capture start, harden cursor import CSV parsing/writes, trim XI2 rest, fail over click watchers on exit, and pass the browser-fallback source through instead of re-reading getSelectedSource().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On X11 + Xvfb hosts the ScreenCast portal often has no METADATA cursor mode, so editable-cursor takes used to write no sidecar. This PR samples the pointer automatically during record (Electron
screen.getCursorScreenPoint(), thenxdotool/xinput/xev/libinput) and writes version-2<video>.cursor.jsonnext to the take.openscreen export --auto-zoomthen works with no extra import step.Also adds
openscreen cursor importfor an external ffmpeg/x11grab CSV track.Follow-up on this branch addresses CodeRabbit’s review of the first revision: discard stops the X11 sampler, fallback samples are compacted by pause ranges, the sampler clock starts at capture start, cursor import CSV/write guards are stricter, XI2 rest no longer accumulates, click watchers fail over on child exit, and the browser fallback keeps the source it just picked.
Related issue
Fixes getopenscreen#1415
Type of change
Release impact
Desktop impact
Repro host (from getopenscreen#1415)
grok-bot-vm-316768464)DISPLAY=:2, Xvfb 1920×1200×24AvailableSourceTypes=0)Behavior
openscreen cursor import --csv mouse.csv --clicks clicks.txt --video take.mp4OPENSCREEN_DISABLE_X11_CURSOR=1/OPENSCREEN_FORCE_X11_CURSOR=1Testing
vitest)tsc --noEmitandtsc -p tsconfig.test.json --noEmitexport --auto-zoomNotes
Upstream PR (same branch): getopenscreen#1416