Skip to content

Add AnonymousEditError and improve error handling #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeMyst wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add AnonymousEditError and improve error handling #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions wikibaseintegrator/wbi_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,8 @@ class MissingEntityException(Exception):

class SearchError(Exception):
pass


class AnonymousEditError(Exception):
"""Raised when an anonymous edit is attempted but allow_anonymous is False"""
pass
8 changes: 4 additions & 4 deletions wikibaseintegrator/wbi_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

from wikibaseintegrator.wbi_backoff import wbi_backoff
from wikibaseintegrator.wbi_config import config
from wikibaseintegrator.wbi_exceptions import MaxRetriesReachedException, ModificationFailed, MWApiError, NonExistentEntityError, SaveFailed, SearchError
from wikibaseintegrator.wbi_exceptions import AnonymousEditError, MaxRetriesReachedException, ModificationFailed, MWApiError, NonExistentEntityError, SaveFailed, SearchError

if TYPE_CHECKING:
from wikibaseintegrator.datatypes import BaseDataType
Expand Down Expand Up @@ -201,8 +201,8 @@ def mediawiki_api_call_helper(data: dict[str, Any], login: _Login | None = None,
data.update({'assert': 'user'})

if 'token' in data and data['token'] == '+\\':
raise Exception("Anonymous edit are not allowed by default. "
"Set allow_anonymous to True to edit mediawiki anonymously or set the login parameter with a valid Login object.")
raise AnonymousEditError("Anonymous edit are not allowed by default. "
"Set allow_anonymous to True to edit mediawiki anonymously or set the login parameter with a valid Login object.")
else:
if 'assert' not in data and login is None:
# Assert anon if allow_anonymous is True and no Login instance
Expand Down Expand Up @@ -282,7 +282,7 @@ def execute_sparql_query(query: str, prefix: str | None = None, endpoint: str |

return results

raise Exception(f"No result after {max_retries} retries.")
raise MaxRetriesReachedException(f"No result after {max_retries} retries.")


def edit_entity(data: dict, id: str | None = None, type: str | None = None, baserevid: int | None = None, summary: str | None = None, clear: bool = False, is_bot: bool = False,
Expand Down
Loading