Skip to content

feat(common): add SavingsPlanDetails.Currency - #345

Merged
cristim merged 1 commit into
mainfrom
feat/savingsplans-currency-field-46
Oct 12, 2026
Merged

cristim merged 1 commit into
mainfrom
feat/savingsplans-currency-field-46

Conversation

@cristim

@cristim cristim commented Oct 12, 2026

Copy link
Copy Markdown
Member

Refs #46

Pkg-only step 1 of 2: adds SavingsPlanDetails.Currency (additive, no behaviour change) so the Azure change can follow with pins bumped to this merge commit. Step 2 (Azure helper, three call sites, tests, pin bumps) carries Closes #46.

🤖 Generated with Claude Code

Refs #46

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@cristim cristim added triaged Item has been triaged priority/p1 Next up; this sprint severity/high Significant harm urgency/this-quarter Within the quarter impact/few Limited audience effort/m Days type/bug Defect labels Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 53 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: b6d6d637-2bc3-4ba2-becc-93a03d6af185

📥 Commits

Reviewing files that changed from the base of the PR and between 4c75a84 and 0b360d9.


📒 Files selected for processing (2)
  • CHANGELOG.md
  • pkg/common/types.go

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

Merge-gate verdict (independent review, claude-opus-5-5): APPROVE at 0b360d91f1957ca2d03bf28dec0c3623301399c5

Scope: diff is only SavingsPlanDetails.Currency + godoc (pkg/common/types.go, +5/-1, the -1 is gofmt realignment of Coverage) and one CHANGELOG entry. Nothing else.

Checks:

Non-blocking note: the godoc's "fails closed when it is empty or malformed" describes the Azure client after step 2 (#344); at this SHA the Azure client still hard-codes USD. The CHANGELOG states the field is unused until then, so this is accurate once #344 lands. No mutation sweep (tiny additive change, per policy).

@cristim
cristim merged commit 3838efd into main Oct 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/m Days impact/few Limited audience priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/bug Defect urgency/this-quarter Within the quarter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant