fix(server): unify generation failure responses - #689
Open
Graffioh wants to merge 1 commit into
Open
Conversation
Graffioh
marked this pull request as ready for review
September 2, 2026 12:27
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Graffioh
marked this pull request as draft
September 2, 2026 12:41
Graffioh
marked this pull request as ready for review
September 2, 2026 19:14
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Requires human review: Auto-approval blocked by 3 unresolved issues from a previous review of this commit.
Re-trigger cubic
Graffioh
force-pushed
the
codex/serving-result-boundary
branch
from
September 2, 2026 19:27
0103420 to
054eaa0
Compare
Graffioh
force-pushed
the
codex/serving-result-boundary
branch
from
September 3, 2026 08:14
054eaa0 to
0c0d312
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResponseErrorboundary that maps typed backend failures onceSseEmitterDesign
This keeps the current execution boundaries intact:
ModelBackend::generate()remains the classic whole-request interfaceSeqEngine::step()remains the concurrent iteration interfaceThe PR deliberately keeps
ParsedRequest,GenerateRequest,GenerateResult,ServerJob,SchedSlot, andDaemonIO. It introduces a name only for the missing server-side failure consequence instead of renaming the pipeline or adding a common generation hierarchy.This is complementary to #688 and does not touch its backend-configuration files.
Client behavior
[DONE]errorevent and no successmessage_stopresponse.failedand noresponse.completedVerification
response_error.cpp,sse_emitter.cpp,http_server.cpp, andscheduler.cppgit diff --checkpassestest_server_unitis left to CI because the local host has neither CUDA nor HIP