refactor(server): establish owned generation lifecycle - #692
Conversation
f5d71f4 to
2f87558
Compare
|
@cubic-dev-ai review this PR |
@Graffioh I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 23 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
f20d5a0 to
4af1d71
Compare
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
4af1d71 to
239bb70
Compare
e657b94 to
66b9295
Compare
78d2990 to
9c541b6
Compare
There was a problem hiding this comment.
All reported issues were addressed across 53 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
8d1961c to
4814c5a
Compare
|
@cubic-dev-ai review this PR |
@Graffioh I have started the AI code review. It will take a few minutes to complete. |
4814c5a to
2e63094
Compare
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
2e63094 to
bd484ae
Compare
Summary
Second PR in the server-refactor stack, directly following #691.
GenerateRequesttoken sequences owned valuesGenerationandGenerationSourcechannel endpointsLuceEngineownModelBackend, the serving thread, mode selection, and orderly joinHttpServerborrow the engine while preserving the established serial worker and concurrent schedulerStack
This is PR 2 of 2:
a567baef92e6309477The #692 commit is directly parented by the current #691 head. Because the branches live in a fork, this PR targets
mainand temporarily displays #691's commits.Review only this PR's 15-file delta: Graffioh/lucebox-hub@codex/backend-plan-boundary...codex/luce-engine-implementation
Current boundary
The server no longer owns backend lifetime and worker-thread lifetime as separate facts. Shutdown asks
LuceEngineto stop and join its selected loop before transport and cache teardown continues.The generation channel is implemented and tested, but is not presented as a live HTTP entry point yet.
HttpServerstill supplies the established serving loops and retains theServerJobqueue. The remaining request-channel andLuceEngine::generate()cutover stays in this PR rather than creating another stacked PR.The current components, ownership, request flows, and shutdown order are documented in server/docs/ENGINE_COMPONENTS.md. It intentionally documents the current system without proposals or open questions.
Verification
a567baef9-> refactor(server): establish owned generation lifecycle #6922e6309477dflash_server, the consolidatedtest_server_unit, andtest_feature_gatebuild on HIP/gfx1151LuceEngineFixtureandGenerationFixturesuites passOff/Auto/Fixedbehavior from refactor(server): seal backend construction behind a plan #691 remains preservedgit diff --checkA broad all-target build reaches and builds
dflash_common, but stops in the unrelated existing HIP testtest_rms_norm_hipbecausecudaErrorNoDeviceis not defined by the compatibility shim.