Skip to content

feat(dfns): add observation types to components #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpbonelli merged 3 commits into from
Oct 6, 2026
Merged

feat(dfns): add observation types to components #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d900c4
feat(dfns): add observation types to components
wpbonelli Oct 6, 2026
b60d40d
refactor(dfns): type observations with input fields
wpbonelli Oct 6, 2026
dff42f9
docs(dfns): trim observation docs
wpbonelli Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-cdb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,5 +289,47 @@
"naux"
]
}
},
"observations": {
"cdb": {
"type": "union",
"tagged": false,
"arms": {
"cellid": {
"type": "array",
"tagged": false,
"dtype": "integer",
"index": true,
"cellid": true,
"shape": [
"ncelldim"
]
},
"boundname": {
"type": "string",
"tagged": false
}
}
},
"to-mvr": {
"type": "union",
"tagged": false,
"arms": {
"cellid": {
"type": "array",
"tagged": false,
"dtype": "integer",
"index": true,
"cellid": true,
"shape": [
"ncelldim"
]
},
"boundname": {
"type": "string",
"tagged": false
}
}
}
}
}
36 changes: 36 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-cdb.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,39 @@ dtype = "string"
shape = [
"naux",
]

[observations.cdb]
type = "union"
tagged = false

[observations.cdb.arms.cellid]
type = "array"
tagged = false
dtype = "integer"
index = true
cellid = true
shape = [
"ncelldim",
]

[observations.cdb.arms.boundname]
type = "string"
tagged = false

[observations.to-mvr]
type = "union"
tagged = false

[observations.to-mvr.arms.cellid]
type = "array"
tagged = false
dtype = "integer"
index = true
cellid = true
shape = [
"ncelldim",
]

[observations.to-mvr.arms.boundname]
type = "string"
tagged = false
31 changes: 31 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-cdb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,34 @@ memory:
dtype: string
shape:
- naux
observations:
cdb:
type: union
tagged: false
arms:
cellid:
type: array
tagged: false
dtype: integer
index: true
cellid: true
shape:
- ncelldim
boundname:
type: string
tagged: false
to-mvr:
type: union
tagged: false
arms:
cellid:
type: array
tagged: false
dtype: integer
index: true
cellid: true
shape:
- ncelldim
boundname:
type: string
tagged: false
22 changes: 22 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-chd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,5 +297,27 @@
"nbound"
]
}
},
"observations": {
"chd": {
"type": "union",
"tagged": false,
"arms": {
"cellid": {
"type": "array",
"tagged": false,
"dtype": "integer",
"index": true,
"cellid": true,
"shape": [
"ncelldim"
]
},
"boundname": {
"type": "string",
"tagged": false
}
}
}
}
}
18 changes: 18 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-chd.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,3 +271,21 @@ shape = [
"naux",
"nbound",
]

[observations.chd]
type = "union"
tagged = false

[observations.chd.arms.cellid]
type = "array"
tagged = false
dtype = "integer"
index = true
cellid = true
shape = [
"ncelldim",
]

[observations.chd.arms.boundname]
type = "string"
tagged = false
16 changes: 16 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-chd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,3 +268,19 @@ memory:
shape:
- naux
- nbound
observations:
chd:
type: union
tagged: false
arms:
cellid:
type: array
tagged: false
dtype: integer
index: true
cellid: true
shape:
- ncelldim
boundname:
type: string
tagged: false
7 changes: 7 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-dfw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,5 +168,12 @@
"nodes"
]
}
},
"observations": {
"ext-outflow": {
"type": "integer",
"tagged": false,
"index": true
}
}
}
5 changes: 5 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-dfw.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,8 @@ dtype = "integer"
shape = [
"nodes",
]

[observations.ext-outflow]
type = "integer"
tagged = false
index = true
5 changes: 5 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-dfw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,8 @@ memory:
dtype: integer
shape:
- nodes
observations:
ext-outflow:
type: integer
tagged: false
index: true
22 changes: 22 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-evp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,5 +307,27 @@
"naux"
]
}
},
"observations": {
"evp": {
"type": "union",
"tagged": false,
"arms": {
"cellid": {
"type": "array",
"tagged": false,
"dtype": "integer",
"index": true,
"cellid": true,
"shape": [
"ncelldim"
]
},
"boundname": {
"type": "string",
"tagged": false
}
}
}
}
}
18 changes: 18 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-evp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,3 +281,21 @@ dtype = "string"
shape = [
"naux",
]

[observations.evp]
type = "union"
tagged = false

[observations.evp.arms.cellid]
type = "array"
tagged = false
dtype = "integer"
index = true
cellid = true
shape = [
"ncelldim",
]

[observations.evp.arms.boundname]
type = "string"
tagged = false
16 changes: 16 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-evp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,3 +278,19 @@ memory:
dtype: string
shape:
- naux
observations:
evp:
type: union
tagged: false
arms:
cellid:
type: array
tagged: false
dtype: integer
index: true
cellid: true
shape:
- ncelldim
boundname:
type: string
tagged: false
42 changes: 42 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-flw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,5 +299,47 @@
"nbound"
]
}
},
"observations": {
"flw": {
"type": "union",
"tagged": false,
"arms": {
"cellid": {
"type": "array",
"tagged": false,
"dtype": "integer",
"index": true,
"cellid": true,
"shape": [
"ncelldim"
]
},
"boundname": {
"type": "string",
"tagged": false
}
}
},
"to-mvr": {
"type": "union",
"tagged": false,
"arms": {
"cellid": {
"type": "array",
"tagged": false,
"dtype": "integer",
"index": true,
"cellid": true,
"shape": [
"ncelldim"
]
},
"boundname": {
"type": "string",
"tagged": false
}
}
}
}
}
36 changes: 36 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/chf-flw.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,3 +273,39 @@ shape = [
"naux",
"nbound",
]

[observations.flw]
type = "union"
tagged = false

[observations.flw.arms.cellid]
type = "array"
tagged = false
dtype = "integer"
index = true
cellid = true
shape = [
"ncelldim",
]

[observations.flw.arms.boundname]
type = "string"
tagged = false

[observations.to-mvr]
type = "union"
tagged = false

[observations.to-mvr.arms.cellid]
type = "array"
tagged = false
dtype = "integer"
index = true
cellid = true
shape = [
"ncelldim",
]

[observations.to-mvr.arms.boundname]
type = "string"
tagged = false
Loading
Loading