Repository navigation
feat(dfns): add observation types to components - #381
Merged
Merged
Conversation
utl-obs's id/id2 union doesn't say which kind of id an observation takes; MF6 decides per observation type and parent. Components accepting an OBS file now list their observation types in `observations`, each narrowing id/id2 to some of the union's arms, with an optional fk for an index. The table is transcribed from each package's id processor in the MF6 Fortran, which covers obstypes the docs omit (API, SWF-family packages) and corrects one they get wrong (GWE LKE's lke takes no ID2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each observation type is now an untagged input field giving what follows it on an observation line, instead of a separate id/id2 vocabulary. A record's first field fills utl-obs's id and its second id2; a union's arms are alternatives. This expresses an id2 that only follows an index (LAK's iconn) or follows a boundname too (UZF's depth) without special cases, and reuses the existing fk and cellid validation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wpbonelli
marked this pull request as ready for review
October 6, 2026 02:06
wpbonelli
added a commit
that referenced
this pull request
Oct 7, 2026
Model name files can have observation files in their packages block but this was missed in #381. Set utl-obs parent = ["model", "package"]. Also obs packages are not really multipackages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
observationsto components that accept an OBS file to specify observation types, so a reader knows e.g. whether3 4is a cellid or two indices