Repository navigation
fix(dfns): accept boundname as ID2 for LAK/MAW connection observations - #382
Merged
Merged
Conversation
…vations MF6 accepts a feature number followed by a boundname for LAK's lak, wetted-area and conductance and MAW's maw and conductance obstypes, observing the boundname and ignoring the number. Add that form as a third union arm. LKT, MWT and MWE read ID2 as a number only, so they keep the two-form union. Name records after all their fields (e.g. ifno_iconn, ifno_boundname) so records that are arms of the same union get distinct names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MF6 accepts
ID BOUNDNAMEfor LAK'slak,wetted-areaandconductanceand MAW'smawandconductanceobstypes, observing the boundname and ignores the number. Thetest042andtest045lake models use this form (e.g.L2WA WETTED-AREA 2 ELAKE02)_connection_or_name, a union of three forms: feature and connection, feature and boundname, or boundname aloneifno_iconn,ifno_boundname) so arms of the same union get distinct names