Skip to content

fix(dfns): accept boundname as ID2 for LAK/MAW connection observations #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpbonelli merged 1 commit into from
Oct 6, 2026
Merged

fix(dfns): accept boundname as ID2 for LAK/MAW connection observations #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-lke.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@
"type": "union",
"tagged": false,
"arms": {
"lakeno": {
"lakeno_lakeno2": {
"type": "record",
"tagged": false,
"fields": {
Expand Down
6 changes: 3 additions & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-lke.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,17 +556,17 @@ tagged = false
type = "union"
tagged = false

[observations.flow-ja-face.arms.lakeno]
[observations.flow-ja-face.arms.lakeno_lakeno2]
type = "record"
tagged = false

[observations.flow-ja-face.arms.lakeno.fields.lakeno]
[observations.flow-ja-face.arms.lakeno_lakeno2.fields.lakeno]
type = "integer"
tagged = false
index = true
fk = "packagedata.lakeno"

[observations.flow-ja-face.arms.lakeno.fields.lakeno2]
[observations.flow-ja-face.arms.lakeno_lakeno2.fields.lakeno2]
type = "integer"
tagged = false
index = true
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-lke.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ observations:
type: union
tagged: false
arms:
lakeno:
lakeno_lakeno2:
type: record
tagged: false
fields:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-mwe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@
"type": "union",
"tagged": false,
"arms": {
"mawno": {
"mawno_iconn": {
"type": "record",
"tagged": false,
"fields": {
Expand Down
6 changes: 3 additions & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-mwe.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,17 +469,17 @@ tagged = false
type = "union"
tagged = false

[observations.mwe.arms.mawno]
[observations.mwe.arms.mawno_iconn]
type = "record"
tagged = false

[observations.mwe.arms.mawno.fields.mawno]
[observations.mwe.arms.mawno_iconn.fields.mawno]
type = "integer"
tagged = false
index = true
fk = "packagedata.mawno"

[observations.mwe.arms.mawno.fields.iconn]
[observations.mwe.arms.mawno_iconn.fields.iconn]
type = "integer"
tagged = false
index = true
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-mwe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ observations:
type: union
tagged: false
arms:
mawno:
mawno_iconn:
type: record
tagged: false
fields:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-sfe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@
"type": "union",
"tagged": false,
"arms": {
"rno": {
"rno_rno2": {
"type": "record",
"tagged": false,
"fields": {
Expand Down
6 changes: 3 additions & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-sfe.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,17 +590,17 @@ tagged = false
type = "union"
tagged = false

[observations.flow-ja-face.arms.rno]
[observations.flow-ja-face.arms.rno_rno2]
type = "record"
tagged = false

[observations.flow-ja-face.arms.rno.fields.rno]
[observations.flow-ja-face.arms.rno_rno2.fields.rno]
type = "integer"
tagged = false
index = true
fk = "packagedata.rno"

[observations.flow-ja-face.arms.rno.fields.rno2]
[observations.flow-ja-face.arms.rno_rno2.fields.rno2]
type = "integer"
tagged = false
index = true
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-sfe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ observations:
type: union
tagged: false
arms:
rno:
rno_rno2:
type: record
tagged: false
fields:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-uze.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@
"type": "union",
"tagged": false,
"arms": {
"uzfno": {
"uzfno_uzfno2": {
"type": "record",
"tagged": false,
"fields": {
Expand Down
6 changes: 3 additions & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-uze.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,17 +480,17 @@ tagged = false
type = "union"
tagged = false

[observations.flow-ja-face.arms.uzfno]
[observations.flow-ja-face.arms.uzfno_uzfno2]
type = "record"
tagged = false

[observations.flow-ja-face.arms.uzfno.fields.uzfno]
[observations.flow-ja-face.arms.uzfno_uzfno2.fields.uzfno]
type = "integer"
tagged = false
index = true
fk = "packagedata.uzfno"

[observations.flow-ja-face.arms.uzfno.fields.uzfno2]
[observations.flow-ja-face.arms.uzfno_uzfno2.fields.uzfno2]
type = "integer"
tagged = false
index = true
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev3/gwe-uze.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ observations:
type: union
tagged: false
arms:
uzfno:
uzfno_uzfno2:
type: record
tagged: false
fields:
Expand Down
54 changes: 51 additions & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/gwf-lak.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@
"type": "union",
"tagged": false,
"arms": {
"ifno": {
"ifno_iconn": {
"type": "record",
"tagged": false,
"fields": {
Expand All @@ -1005,6 +1005,22 @@
}
}
},
"ifno_boundname": {
"type": "record",
"tagged": false,
"fields": {
"ifno": {
"type": "integer",
"tagged": false,
"index": true,
"fk": "packagedata.ifno"
},
"boundname": {
"type": "string",
"tagged": false
}
}
},
"boundname": {
"type": "string",
"tagged": false
Expand All @@ -1015,7 +1031,7 @@
"type": "union",
"tagged": false,
"arms": {
"ifno": {
"ifno_iconn": {
"type": "record",
"tagged": false,
"fields": {
Expand All @@ -1032,6 +1048,22 @@
}
}
},
"ifno_boundname": {
"type": "record",
"tagged": false,
"fields": {
"ifno": {
"type": "integer",
"tagged": false,
"index": true,
"fk": "packagedata.ifno"
},
"boundname": {
"type": "string",
"tagged": false
}
}
},
"boundname": {
"type": "string",
"tagged": false
Expand All @@ -1042,7 +1074,7 @@
"type": "union",
"tagged": false,
"arms": {
"ifno": {
"ifno_iconn": {
"type": "record",
"tagged": false,
"fields": {
Expand All @@ -1059,6 +1091,22 @@
}
}
},
"ifno_boundname": {
"type": "record",
"tagged": false,
"fields": {
"ifno": {
"type": "integer",
"tagged": false,
"index": true,
"fk": "packagedata.ifno"
},
"boundname": {
"type": "string",
"tagged": false
}
}
},
"boundname": {
"type": "string",
"tagged": false
Expand Down
60 changes: 51 additions & 9 deletions autotest/dfns/__snapshots__/v2.0.0.dev3/gwf-lak.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,21 +877,35 @@ tagged = false
type = "union"
tagged = false

[observations.lak.arms.ifno]
[observations.lak.arms.ifno_iconn]
type = "record"
tagged = false

[observations.lak.arms.ifno.fields.ifno]
[observations.lak.arms.ifno_iconn.fields.ifno]
type = "integer"
tagged = false
index = true
fk = "packagedata.ifno"

[observations.lak.arms.ifno.fields.iconn]
[observations.lak.arms.ifno_iconn.fields.iconn]
type = "integer"
tagged = false
index = true

[observations.lak.arms.ifno_boundname]
type = "record"
tagged = false

[observations.lak.arms.ifno_boundname.fields.ifno]
type = "integer"
tagged = false
index = true
fk = "packagedata.ifno"

[observations.lak.arms.ifno_boundname.fields.boundname]
type = "string"
tagged = false

[observations.lak.arms.boundname]
type = "string"
tagged = false
Expand All @@ -900,21 +914,35 @@ tagged = false
type = "union"
tagged = false

[observations.wetted-area.arms.ifno]
[observations.wetted-area.arms.ifno_iconn]
type = "record"
tagged = false

[observations.wetted-area.arms.ifno.fields.ifno]
[observations.wetted-area.arms.ifno_iconn.fields.ifno]
type = "integer"
tagged = false
index = true
fk = "packagedata.ifno"

[observations.wetted-area.arms.ifno.fields.iconn]
[observations.wetted-area.arms.ifno_iconn.fields.iconn]
type = "integer"
tagged = false
index = true

[observations.wetted-area.arms.ifno_boundname]
type = "record"
tagged = false

[observations.wetted-area.arms.ifno_boundname.fields.ifno]
type = "integer"
tagged = false
index = true
fk = "packagedata.ifno"

[observations.wetted-area.arms.ifno_boundname.fields.boundname]
type = "string"
tagged = false

[observations.wetted-area.arms.boundname]
type = "string"
tagged = false
Expand All @@ -923,20 +951,34 @@ tagged = false
type = "union"
tagged = false

[observations.conductance.arms.ifno]
[observations.conductance.arms.ifno_iconn]
type = "record"
tagged = false

[observations.conductance.arms.ifno.fields.ifno]
[observations.conductance.arms.ifno_iconn.fields.ifno]
type = "integer"
tagged = false
index = true
fk = "packagedata.ifno"

[observations.conductance.arms.ifno.fields.iconn]
[observations.conductance.arms.ifno_iconn.fields.iconn]
type = "integer"
tagged = false
index = true

[observations.conductance.arms.ifno_boundname]
type = "record"
tagged = false

[observations.conductance.arms.ifno_boundname.fields.ifno]
type = "integer"
tagged = false
index = true
fk = "packagedata.ifno"

[observations.conductance.arms.ifno_boundname.fields.boundname]
type = "string"
tagged = false

[observations.conductance.arms.boundname]
type = "string"
Expand Down
Loading
Loading