Repository navigation
fix(dfns): admit utl-obs under models and make it single-instance - #384
Merged
Merged
Conversation
Model name files with observation types (chf, gwe, gwf, gwt, olf) read an OBS6 file from their packages block, so treat them as linkers of utl-obs in link_components. Its derived parent becomes ["model", "package"]. MF6 reads at most one OBS6 per parent (packages error on a second, models keep the last), so override flopy3's multi-package header for utl-obs: multi is now false. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wpbonelli
marked this pull request as ready for review
October 7, 2026 20:07
wpbonelli
added a commit
to modflowpy/pyphoenix-project
that referenced
this pull request
Oct 8, 2026
Bump devtools for MODFLOW-ORG/modflow-devtools#384, which admits utl-obs for models and makes it single-instance. Remove the special casing from #417. Skip models without obs (e.g. prt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model name files can have observation files in their packages block but this was missed in #381. Set utl-obs
parent = ["model", "package"]. Also obs packages are not really multipackages.