Docker isolation, proven with a real run: evidence and recommendation - #25
Open
nishantkluhera wants to merge 1 commit into
Open
Docker isolation, proven with a real run: evidence and recommendation#25nishantkluhera wants to merge 1 commit into
nishantkluhera wants to merge 1 commit into
Conversation
Read base.py + the 2,050-line docker backend end to end: enabling is two config keys (terminal.backend + optional docker_image), one long-lived labeled container per (task, profile) with cross-process reuse and an orphan reaper, cap-drop-ALL hardening, and deliberate secret non-forwarding. Live evidence on this machine (Docker Desktop 29.0.1/WSL2), driving the real DockerEnvironment class: cold start 1.27s, warm exec 0.17s, host GITHUB_TOKEN verifiably absent inside the container (probed both with and without a host token), public clones + pip installs work, private auth correctly fails without egress-proxy tokens. Recommendation: docker backend for unattended runs against repos that aren't ours, paired with hermes egress enforce_on_docker; local stays for interactive sessions. Latency fear retired by measurement. Closes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplementary measured evidence for #4 (closed): live runs through the real DockerEnvironment on Docker Desktop 29.0.1/WSL2 - cold start 1.27s, warm exec 0.17s, host GITHUB_TOKEN verifiably absent inside the container (probed with and without a host token), public clones + pip installs work, private auth correctly fails without egress tokens.
Recommendation recorded: docker backend for unattended runs against repos that aren't ours, paired with hermes egress enforce_on_docker.
Doc in mershlab/research/. Merge order: #24 first, then this.