mrbind: pass -Wno-enum-constexpr-conversion only to old Clang (18, 19)#6325
Merged
Conversation
This flag is only needed by the older Clang versions we use as parsers, so move it out of the always-on common_compiler_parser_flags.txt and add it conditionally in generate.mk, only when CXX_FOR_BINDINGS is Clang 18 or 19. This mirrors how -frelaxed-template-template-args is already gated nearby.
adalisk-emikhaylov
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #4750.
-Wno-enum-constexpr-conversionis only needed by the older Clang versions we use as parsers, so it shouldn't be passed unconditionally. This moves it out of the always-oncommon_compiler_parser_flags.txtand adds it ingenerate.mkonly whenCXX_FOR_BINDINGSreports Clang 18 or 19:This mirrors how the neighboring
-frelaxed-template-template-argsis already gated to older Clang.Scope note
The original change in #4750 also moved
-frelaxed-template-template-args. That flag is already handled on master (added conditionally viaclang --help), so this PR touches only-Wno-enum-constexpr-conversion.It does mean the flag is no longer passed to the Clang 21 (Linux vcpkg) and Clang 22 (macOS / Windows) binding builds — CI on those platforms confirms they still build without it.