Skip to content

mrbind: pass -Wno-enum-constexpr-conversion only to old Clang (18, 19) #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fedr merged 1 commit into from
Jun 25, 2026
Merged

mrbind: pass -Wno-enum-constexpr-conversion only to old Clang (18, 19) #6325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion scripts/mrbind/common_compiler_parser_flags.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
-std=c++23
-Wno-nonportable-include-path
-Wno-enum-constexpr-conversion
-Wno-deprecated-enum-enum-conversion
-D_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH
4 changes: 4 additions & 0 deletions scripts/mrbind/generate.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,10 @@ COMPILER_FLAGS := $(ABI_COMPAT_FLAG) $(EXTRA_CFLAGS) $(call load_file,$(makefile
# Add `-frelaxed-template-template-args` if Clang is old enough to support it. Newer versions have this behavior by default.
# Clang 18 and older need this flag. Clang 19 and 20 do the right thing by default, but still allow the flag with a deprecation warning. Clang 21 and newer consider this an unknown flag and error.
COMPILER_FLAGS += $(shell $(CXX_FOR_BINDINGS) --help | grep -o -- -frelaxed-template-template-args)
# `-Wno-enum-constexpr-conversion` is only needed by the older Clang versions (18, 19); pass it only there.
ifneq ($(filter 18 19,$(call safe_shell,$(CXX_FOR_BINDINGS) -dumpversion | cut -d. -f1)),)
COMPILER_FLAGS += -Wno-enum-constexpr-conversion
endif
ifneq ($(DEPS_INCLUDE_DIR),)
# Required for vcpkg environments
COMPILER_FLAGS += -I$(DEPS_INCLUDE_DIR)/eigen3
Expand Down
Loading