Skip to content

update ownership on geolocation controller package to mobile platform#8496

Open
tommasini wants to merge 1 commit intomainfrom
chore/update-geolocation-ownership
Open

update ownership on geolocation controller package to mobile platform#8496
tommasini wants to merge 1 commit intomainfrom
chore/update-geolocation-ownership

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Apr 16, 2026

Explanation

Update code ownership of geolocation-controller to mobile platform.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
CODEOWNERS-only change that affects review routing but does not modify runtime code or behavior.

Overview
Updates .github/CODEOWNERS so /packages/geolocation-controller is owned by @MetaMask/mobile-platform instead of @MetaMask/core-platform, shifting review responsibility for that package.

Reviewed by Cursor Bugbot for commit 742501c. Bugbot is set up for automated code reviews on this repo. Configure here.

@tommasini tommasini requested a review from a team as a code owner April 16, 2026 17:25
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 742501c. Configure here.

Comment thread .github/CODEOWNERS

## Mobile Platform Team
/packages/app-metadata-controller @MetaMask/mobile-platform
/packages/geolocation-controller @MetaMask/mobile-platform
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teams.json not updated for ownership transfer

Medium Severity

The CODEOWNERS file explicitly states to keep it synchronized with teams.json (line 4). The main CODEOWNERS section now assigns geolocation-controller to @MetaMask/mobile-platform, but teams.json still maps "metamask/geolocation-controller" to "team-core-platform". This inconsistency means automated workflows using teams.json will still route issues to the wrong team.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 742501c. Configure here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. teams.json is used within the workflow that automatically creates tickets when new major versions of packages are released. Can you update that file as well?

Comment thread .github/CODEOWNERS
/packages/build-utils @MetaMask/core-platform
/packages/composable-controller @MetaMask/core-platform
/packages/connectivity-controller @MetaMask/core-platform
/packages/geolocation-controller @MetaMask/core-platform
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package release CODEOWNERS entries not updated for new owner

Medium Severity

The "Package Release related" section still assigns geolocation-controller/package.json and CHANGELOG.md ownership solely to @MetaMask/core-platform. Other mobile-platform packages (like app-metadata-controller) include @MetaMask/mobile-platform in these entries. The new owning team won't be required reviewers for release-related file changes.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 742501c. Configure here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true. We do still need entries for package.json and CHANGELOG.md but we should make sure that your team is included in these entries otherwise they will only be assigned to our team (when GitHub reads lines in the CODEOWNERS file, later lines can override previous lines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants