Skip to content

update ownership on geolocation controller package to mobile platform #8496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tommasini wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

update ownership on geolocation controller package to mobile platform #8496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@

## Mobile Platform Team
/packages/app-metadata-controller @MetaMask/mobile-platform
/packages/geolocation-controller @MetaMask/mobile-platform
Copy link
Copy Markdown

@cursor cursor bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teams.json not updated for ownership transfer

Medium Severity

The CODEOWNERS file explicitly states to keep it synchronized with teams.json (line 4). The main CODEOWNERS section now assigns geolocation-controller to @MetaMask/mobile-platform, but teams.json still maps "metamask/geolocation-controller" to "team-core-platform". This inconsistency means automated workflows using teams.json will still route issues to the wrong team.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 742501c. Configure here.

Copy link
Copy Markdown
Contributor

@mcmire mcmire Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. teams.json is used within the workflow that automatically creates tickets when new major versions of packages are released. Can you update that file as well?

/packages/analytics-controller @MetaMask/mobile-platform @MetaMask/extension-platform
/packages/analytics-data-regulation-controller @MetaMask/mobile-platform @MetaMask/extension-platform

Expand All @@ -80,7 +81,6 @@
/packages/build-utils @MetaMask/core-platform
/packages/composable-controller @MetaMask/core-platform
/packages/connectivity-controller @MetaMask/core-platform
/packages/geolocation-controller @MetaMask/core-platform
Copy link
Copy Markdown

@cursor cursor bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package release CODEOWNERS entries not updated for new owner

Medium Severity

The "Package Release related" section still assigns geolocation-controller/package.json and CHANGELOG.md ownership solely to @MetaMask/core-platform. Other mobile-platform packages (like app-metadata-controller) include @MetaMask/mobile-platform in these entries. The new owning team won't be required reviewers for release-related file changes.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 742501c. Configure here.

Copy link
Copy Markdown
Contributor

@mcmire mcmire Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true. We do still need entries for package.json and CHANGELOG.md but we should make sure that your team is included in these entries otherwise they will only be assigned to our team (when GitHub reads lines in the CODEOWNERS file, later lines can override previous lines).

/packages/controller-utils @MetaMask/core-platform
/packages/error-reporting-service @MetaMask/core-platform
/packages/eth-json-rpc-middleware @MetaMask/core-platform
Expand Down
Loading