refactor(tron-wallet-snap): extract SnapAssetsAdapter from existing AssetsService logic

[ulissesferreira]

Summary

• Extract legacy assets logic into adapters/SnapAssetsAdapter.ts
• Replace AssetsService with a thin facade that delegates all public methods to the snap adapter

Jira

• WPN-1497 — Stage 0→1 prep (shared spine)
• Parent: WPN-1478

Test plan

• yarn workspace @metamask/tron-wallet-snap build
• yarn workspace @metamask/tron-wallet-snap run test

Stacks on #90 (Step 2/3).

[ulissesferreira]

@cursoragent rebase with latest main

[cursor]

Rebased onto latest main and fixed the follow-up CI issue.

Rebase

• Rebased WPN-1497-snap-adapter onto origin/main (27aa57bc — feat: tron v2 feat: tron v2 #56)
• Resolved conflicts in packages/tron-wallet-snap/snap.manifest.json during rebase
• Force-pushed the rebased branch

Shasum fix

After the rebase, CI failed on the manifest shasum (same issue as before — Linux CI uses secret mainnet RPC URLs). Updated to the CI-expected value:

d+4EA5VWJknz8ahgtwMFrhFIp/RohdmBbKWZmc5IeYo=

Verification

• yarn lint — passed
• yarn workspace @metamask/tron-wallet-snap run test — passed

PR #91: #91

  

[ulissesferreira]

@cursoragent rebase latest main resolving conflicts, lint and update shasum

[cursor]

Rebased onto latest main, resolved conflicts, linted, and updated the manifest shasum.

Rebase

• Rebased WPN-1497-snap-adapter onto origin/main (b1440657 — fix: replace computed Network enum initialisers with string literals fix: replace computed Network enum initialisers with string literals #101)
• Resolved conflicts in packages/tron-wallet-snap/snap.manifest.json (shasum conflicts in two commits)
• Force-pushed the rebased branch

Shasum

Linux CI uses secret mainnet RPC URLs, so the local shasum (SNtdYF0JkH5ubXZTB4QQnEow8OrOwBBAeXEr7YDtWxA=) did not match CI. Updated to the CI-expected value from the failed build job:

TEEXgH0mFwQ1x70iGzw0kNN7P/lPzIiLa+ATCM2v/vY=

Verification

• yarn lint — passed
• yarn workspace @metamask/tron-wallet-snap run test — passed
• CI — build, lint, and all test jobs green (including tron-wallet-snap on Node 20.x and 22.x)

PR #91: #91

  

[gabrieledm]

Few comments:

• Are we sure about to discard the comments from github-advanced-security with WONT_FIX ?
• Are we sure the file packages/tron-wallet-snap/src/services/assets/adapters/SnapAssetsAdapter.test.ts is not needed ?
  • Or is it planned to add iit in another PR ?

[ulissesferreira]

Few comments:

* Are we sure about to discard the comments from `github-advanced-security` with `WONT_FIX` ?

* Are we sure the file `packages/tron-wallet-snap/src/services/assets/adapters/SnapAssetsAdapter.test.ts` is not needed ?
  
  * Or is it planned to add iit in another PR ?

github-advanced-security > yes because the code is already existing one and we want minimal changes during the migration to the new logic. I guess we only got notified of them because it was detected as changes. But we want to move as little as possible.

packages/tron-wallet-snap/src/services/assets/adapters/SnapAssetsAdapter.test.ts - hmmm I see what you mean, it's kinda useless right? Well it will be changes in one of the follow up PRs

[gabrieledm]

github-advanced-security > yes because the code is already existing one and we want minimal changes during the migration to the new logic. I guess we only got notified of them because it was detected as changes. But we want to move as little as possible.

packages/tron-wallet-snap/src/services/assets/adapters/SnapAssetsAdapter.test.ts - hmmm I see what you mean, it's kinda useless right? Well it will be changes in one of the follow up PRs

Makes sense.
Happy to give a review for the additional PRs

[ulissesferreira]

@cursoragent rebase with latest main, make sure lint is good and then babysit the PR until green

[cursor]

Rebased onto latest main, lint passed, and CI is green on PR #91.

Rebase

• Rebased onto origin/main (69a28dea — chore: solana wallet snap integrate packages chore: solana wallet snap integrate packages #72), which also includes fix(tron-wallet-snap): stop wrapping submitRequest response in v1 KeyringResponse envelope #105 and Release/4.0.0 #106
• Resolved snap.manifest.json shasum conflicts during rebase
• Ran yarn install after the solana package integration (new workspace dependencies)
• Force-pushed the rebased branch

Lint & tests

• yarn lint — passed
• yarn workspace @metamask/tron-wallet-snap run test — passed

Shasum

Linux CI uses secret mainnet RPC URLs, so the local value did not match. Updated to the CI-expected value:

uocZF1RsEzCWGmRM3X3mMv42laNfJWpwVXOfNViikl8=

CI status — green

All 49 checks passed (0 failed), including:

• Build (24.x)
• All lint jobs
• All test jobs (bitcoin, solana, snap-networks-utils, tron-wallet-snap on Node 20.x and 22.x)
• Security scans (CodeQL, Semgrep, zizmor)
• Main / All jobs pass (required)

PR is mergeable (mergeable: true). mergeable_state: blocked is likely from review/approval requirements, not CI.

PR #91: #91