refactor(tron-wallet-snap): rename SNAP_SPECIAL_ASSETS to SNAP_OWNED_ASSETS - #92
Draft
ulissesferreira wants to merge 12 commits into
Draft
refactor(tron-wallet-snap): rename SNAP_SPECIAL_ASSETS to SNAP_OWNED_ASSETS#92ulissesferreira wants to merge 12 commits into
ulissesferreira wants to merge 12 commits into
Conversation
This was referenced Jul 31, 2026
ulissesferreira
force-pushed
the
WPN-1497-snap-adapter
branch
from
July 31, 2026 21:54
53be776 to
b517134
Compare
ulissesferreira
changed the title
This was referenced Jul 31, 2026
ulissesferreira
force-pushed
the
WPN-1497-snap-owned-helpers
branch
from
July 31, 2026 22:18
b67ea64 to
8624473
Compare
This was referenced Aug 2, 2026
ulissesferreira
marked this pull request as draft
August 2, 2026 17:39
ulissesferreira
force-pushed
the
WPN-1497-snap-adapter
branch
from
August 2, 2026 20:48
80da50f to
8b77a78
Compare
ulissesferreira
force-pushed
the
WPN-1497-snap-owned-helpers
branch
2 times, most recently
from
August 2, 2026 23:20
d5876a7 to
81eb154
Compare
ulissesferreira
force-pushed
the
WPN-1497-snap-adapter
branch
from
August 2, 2026 23:20
8b77a78 to
30a99f6
Compare
2 tasks
cursor
Bot
force-pushed
the
WPN-1497-snap-adapter
branch
3 times, most recently
from
August 4, 2026 10:12
da939f6 to
cb7a717
Compare
Contributor
Author
|
@cursoragent rebase with the latest base. then confirm linting is good, and finally that the shasum is correct |
|
All three items are done. RebaseRebased
Lint
ShasumBuilt with
Tests
The branch has been force-pushed and PR #92 is updated: #92   |
cursor
Bot
force-pushed
the
WPN-1497-snap-owned-helpers
branch
from
August 4, 2026 10:39
81eb154 to
e49c38b
Compare
Contributor
Author
|
@cursoragent update the shasum for this |
|
Updated the manifest shasum to match what Linux CI computes.
CI was failing because the build step auto-corrects the shasum on Linux, leaving a dirty working tree. The fix is committed in |
…rvice Move existing assets logic into SnapAssetsAdapter and keep AssetsService as a thin facade that always delegates to the Snap adapter. Behavior unchanged; prepares for a later Core adapter / feature-flag routing PR.
Adapter lives one directory deeper than AssetsService; bump client, constants, and types imports to ../../../ and ../types respectively.
Update the manifest shasum, cover AssetsService facade delegation in tests, and use SnapAssetsAdapter.isFiat inside the adapter implementation.
Move import suppressions to SnapAssetsAdapter and align test assertions with jest prefer-strict-equal rules.
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Align test file formatting with lint:misc:check expectations.
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
ulissesferreira
force-pushed
the
WPN-1497-snap-owned-helpers
branch
from
August 4, 2026 13:45
2242a06 to
8d95d05
Compare
ulissesferreira
force-pushed
the
WPN-1497-snap-adapter
branch
from
August 4, 2026 13:45
5e27de9 to
9532cbd
Compare
cursor
Bot
force-pushed
the
WPN-1497-snap-adapter
branch
2 times, most recently
from
August 4, 2026 16:23
a122613 to
772082a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SNAP_OWNED_ASSETSconstant (with deprecatedSPECIAL_ASSETSalias)isSnapOwnedAsset()helper and unit testsJira
Test plan
yarn workspace @metamask/tron-wallet-snap buildyarn workspace @metamask/tron-wallet-snap run testStacks on #91 (Step 3/3 shared spine). Merge before choosing Fork X or Y.