Fix Rotten Tomatoes Audience rating source mismatch#148
Open
mattsigal wants to merge 1 commit into
Open
Conversation
- Map rtAudience (legacy web) and tomatoes_audience (client) to popcorn when fetching from MDBList API. - Return ratings with the tomatoes_audience source key to match the client's expected key. - Update the server config page configuration list to use tomatoes_audience and dynamically map any existing rtAudience configurations to tomatoes_audience during load. - Normalize rtAudience settings in the resolved user settings profiles in memory.
Build SuccessfulThe plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.
|
mattsigal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotten Tomatoes audience rating scores (the "popcornometer") were not rendering in the UI because of divergent source keys across the system: MDBList API returns the score source as
popcorn, while the client app requeststomatoes_audience, and the server plugin configuration page usedrtAudience. This mismatch caused the server's rating proxy to filter out the audience rating.This pull request resolves the issue by normalizing the keys on the server side:
rtAudienceandtomatoes_audiencetopopcornwhen querying the MDBList API.tomatoes_audiencekey so that client apps receive it correctly.rtAudiencetotomatoes_audiencein memory inside the resolved settings profiles.rtAudiencetotomatoes_audience, with compatibility to map legacy configs on load.Changes Made
MdbListController.csto handle key translation for API lookups and returns.MoonfinSettingsService.csto normalize rating source profiles.configPage.htmlto update picker source IDs and load mapping.