chore(review): remove per-repo custom-codereview-guide skill by Coldaine · Pull Request #249 · MooseGooseConsulting/RobotOverview

Coldaine · 2026-08-16T21:11:31Z

User description

What

Removes .agents/skills/custom-codereview-guide.md (the OpenHands-documented
"Option 1: Custom Code Review Skill" per-repo overlay) and its references:

Deletes the skill file.
tools/ci/test_cold_review_workflow.py: drops the SKILL constant and its
assertions; test_workflow_and_skill_paths_exist → test_workflow_path_exists.
.github/workflows/ci-tools-tests.yml: removes the two path filters for the
deleted skill.

Why

The review-guidance content (commit hygiene, Renovate, severity format) already
ships with the pr-review plugin's bundled /codereview skill, pulled from
OpenHands/extensions at main — the generalized prompt lives where the bot
lives, not per-repo. RobotOverview-specific boundaries (Hangar vs BEAST-01,
Postgres-is-truth) still reach the reviewer through AGENTS.md (the plugin's
documented "Option 2" channel). The reviewer is verified live: label, env,
secrets, App, runner group all present; runs execute on this repo today.

Tracked elsewhere

Workshopping/upgrading the upstream generalized prompt: coldaine-codeOps#7.

CodeAnt-AI Description

Remove the repository-specific code review overlay

What Changed

Removes the repository-local code review guide so reviews use the shared review guidance instead
Updates workflow contract tests to verify only the cold-review workflow exists
Stops running CI tools tests specifically when the deleted guide changes

Impact

✅ One shared source for review guidance
✅ Fewer obsolete review-guide checks
✅ Cleaner CI path filtering

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@main

The skill was an OpenHands Option-1 overlay duplicating guidance that ships with the pr-review plugin's bundled /codereview skill (upstream @main). The generalized prompt stays upstream; repo-specific rules reach the reviewer via AGENTS.md. Tracking the upstream prompt upgrade in coldaine-codeOps#7.

codeant-ai · 2026-08-16T21:11:37Z

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	`0471861`	Aug 16, 2026 · 21:11	21:13

codeant-ai · 2026-08-16T21:11:37Z

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Copilot

Pull request overview

Removes the repository-local OpenHands “custom code review overlay” skill so cold reviews rely on the upstream /codereview guidance, with RobotOverview-specific constraints continuing to flow through AGENTS.md. This simplifies the workflow contract tests and CI path filtering by eliminating checks and triggers tied to the deleted skill file.

Changes:

Deleted .agents/skills/custom-codereview-guide.md.
Simplified tools/ci/test_cold_review_workflow.py to assert only the cold-review workflow path exists (and removed skill-content assertions).
Removed CI path filters in .github/workflows/ci-tools-tests.yml that referenced the deleted skill file.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tools/ci/test_cold_review_workflow.py	Drops the skill contract checks; keeps workflow-only contract assertions.
.github/workflows/ci-tools-tests.yml	Removes path triggers for the deleted skill file in PR/push filters.
.agents/skills/custom-codereview-guide.md	Deleted repository-specific review overlay skill.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

qodo-code-review · 2026-08-16T21:12:54Z

PR Summary by Qodo

Remove per-repo custom /codereview skill overlay and references

⚙️ Configuration changes 🧪 Tests 🕐 10-20 Minutes

AI Description

• Delete the per-repo OpenHands custom code review skill overlay
• Simplify CI contract tests to validate only the cold-review workflow file
• Remove GitHub Actions path filters referencing the deleted skill

Diagram

graph TD
  ci["ci-tools-tests.yml"] --> gha["CI tools tests"] --> contract(["cold-review contract test"]) --> coldwf["cold-review.yml"] --> upstream{{"Bundled /codereview skill"}}
  contract -. "drops custom skill checks" .-> removed["custom skill (removed)"]

  subgraph Legend
    direction LR
    _file["File"] ~~~ _test(["Test"]) ~~~ _ext{{"External/bundled"}}
  end

High-Level Assessment

The following are alternative approaches to this PR:

1. Keep a thin repo-local skill as a shim/redirect

➕ Preserves a stable repo-level anchor even if upstream skill name/content moves
➕ Allows incremental repo-specific overrides without changing plugin behavior
➖ Reintroduces duplication/maintenance burden the PR is removing
➖ Creates ambiguity about source-of-truth for review guidance

2. Pin the reviewer skill source to a versioned extension reference

➕ Reduces risk of upstream prompt drift changing review behavior unexpectedly
➕ Improves reproducibility across time
➖ Requires ongoing version bump management
➖ May delay receiving upstream improvements/fixes

Recommendation: Proceed with this PR’s approach (remove the repo-local overlay and validate only the workflow contract), since the guidance is intentionally centralized with the reviewer plugin and repo-specific rules can live in AGENTS.md. If upstream drift becomes a concern, consider pinning the plugin/extension reference rather than reintroducing a per-repo custom skill.

Files changed (2) +2 / -10

Tests (1) +2 / -8

test_cold_review_workflow.pySimplify contract test to only assert workflow existence +2/-8

Simplify contract test to only assert workflow existence

• Updates the module purpose/comments and removes the 'SKILL' constant plus assertions that enforced the presence and contents of the custom skill. Renames the path existence test to reflect the new single responsibility (workflow-only).

tools/ci/test_cold_review_workflow.py

Other (1) +0 / -2

ci-tools-tests.ymlRemove path filters for deleted custom review skill +0/-2

Remove path filters for deleted custom review skill
• Drops the path filters that referenced '.agents/skills/custom-codereview-guide.md' from the CI tools tests workflow triggers. Prevents CI configuration from pointing at a removed file.
.github/workflows/ci-tools-tests.yml

kilo-code-bot · 2026-08-16T21:13:35Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

.agents/skills/custom-codereview-guide.md — deleted
.github/workflows/ci-tools-tests.yml — removed 2 path filters, no issues
tools/ci/test_cold_review_workflow.py — removed skill constant and assertions, no issues

Documentation Note

This PR correctly removes the per-repo custom-codereview-guide overlay in favor of the upstream bundled /codereview skill plus AGENTS.md for repo-specific boundaries (monorepo separation, Postgres-is-truth, content workflow). The review delivery format guidance (severity grouping, suggestion blocks) now lives upstream with the pr-review plugin, matching the PR description.

Model/thinking level: step-3.7-flash (free tier), default reasoning — more limited than the production cold-review workflow's gpt-5.6-luna/xhigh configuration.

Stale Documentation (Out of Scope)

docs/plans/ contains several 2026-08-02 plans that assert a cmd_vel_timeout safety net removed in #174. Per docs/plans/README.md ("Executed plans are deleted, not archived"), the 2026-08-14-beast-vendor-parked-surface-and-doc-drift.md plan (D16) flags these for deletion. Not addressed by this PR but a follow-up is warranted.

_{Reviewed by step-3.7-flash · Input: 59.2K · Output: 6.4K · Cached: 249.2K}

qodo-code-review · 2026-08-16T21:13:41Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

qodo-code-review · 2026-08-16T21:13:52Z

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

Copilot AI lite review requested due to automatic review settings August 16, 2026 21:11

Coldaine had a problem deploying to openhands-review August 16, 2026 21:11 — with GitHub Actions Error

Copilot started reviewing on behalf of Coldaine August 16, 2026 21:12 View session

codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Aug 16, 2026

Copilot AI reviewed Aug 16, 2026

View reviewed changes

qodo-code-review Bot added 🕐 10-20 Minutes and removed size:XS This PR changes 0-9 lines, ignoring generated files labels Aug 16, 2026

Coldaine merged commit 69e1bf6 into main Aug 16, 2026
8 of 9 checks passed

Coldaine deleted the chore/remove-repo-review-skill branch August 16, 2026 21:43

Navigation Menu

Uh oh!

chore(review): remove per-repo custom-codereview-guide skill - #249

chore(review): remove per-repo custom-codereview-guide skill#249
Coldaine merged 1 commit into
mainfrom
chore/remove-repo-review-skill

Coldaine commented Aug 16, 2026 •

edited by codeant-ai Bot

Loading

Uh oh!

codeant-ai Bot commented Aug 16, 2026 •

edited

Loading

Uh oh!

codeant-ai Bot commented Aug 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

qodo-code-review Bot commented Aug 16, 2026

Uh oh!

kilo-code-bot Bot commented Aug 16, 2026 •

edited

Loading

Uh oh!

qodo-code-review Bot commented Aug 16, 2026

Uh oh!

qodo-code-review Bot commented Aug 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Coldaine commented Aug 16, 2026 • edited by codeant-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

What

Why

Tracked elsewhere

CodeAnt-AI Description

What Changed

Impact

Checking Your Pull Request

Talking to CodeAnt AI

Example

Preserve Org Learnings with CodeAnt

Example

Retrigger review

Check Your Repository Health

Uh oh!

codeant-ai Bot commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CodeAnt AI — Review Status

Uh oh!

codeant-ai Bot commented Aug 16, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

qodo-code-review Bot commented Aug 16, 2026

PR Summary by Qodo

Uh oh!

kilo-code-bot Bot commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Documentation Note

Stale Documentation (Out of Scope)

Uh oh!

qodo-code-review Bot commented Aug 16, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

qodo-code-review Bot commented Aug 16, 2026

Qodo Fixer

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Coldaine commented Aug 16, 2026 •

edited by codeant-ai Bot

Loading

codeant-ai Bot commented Aug 16, 2026 •

edited

Loading

kilo-code-bot Bot commented Aug 16, 2026 •

edited

Loading