Skip to content

chore(review): remove per-repo custom-codereview-guide skill #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Coldaine merged 1 commit into from
Aug 16, 2026
Merged

chore(review): remove per-repo custom-codereview-guide skill #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions .agents/skills/custom-codereview-guide.md
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions .github/workflows/ci-tools-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ on:
- '.github/workflows/beast-ros-image.yml'
- '.github/workflows/cold-review.yml'
- '.github/actionlint.yaml'
- '.agents/skills/custom-codereview-guide.md'
push:
branches: [main]
paths:
Expand All @@ -52,7 +51,6 @@ on:
- '.github/workflows/beast-ros-image.yml'
- '.github/workflows/cold-review.yml'
- '.github/actionlint.yaml'
- '.agents/skills/custom-codereview-guide.md'

permissions:
contents: read
Expand Down
10 changes: 2 additions & 8 deletions tools/ci/test_cold_review_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Copyright 2026 Coldaine
# SPDX-License-Identifier: Apache-2.0
"""Contract tests for the OpenHands Cold Review workflow and skill.
"""Contract tests for the OpenHands Cold Review workflow.

These are the cheap checks that notice a silent regression (wrong model,
effort flag hacks, pull_request_target, missing auth cleanup) before a
Expand All @@ -15,7 +15,6 @@

REPO = Path(__file__).resolve().parents[2]
WORKFLOW = REPO / ".github" / "workflows" / "cold-review.yml"
SKILL = REPO / ".agents" / "skills" / "custom-codereview-guide.md"


def _load_workflow() -> dict:
Expand All @@ -29,13 +28,8 @@ def _on(wf: dict) -> dict:
return wf.get("on") or wf[True]


def test_workflow_and_skill_paths_exist():
def test_workflow_path_exists():
assert WORKFLOW.is_file()
assert SKILL.is_file()
assert SKILL.name != "code-review.md"
skill = SKILL.read_text(encoding="utf-8")
assert "triggers:" in skill
assert "/codereview" in skill


def test_triggers_and_guards():
Expand Down
Loading