Skip to content

fix(install): enable TBB by default on Linux - #119

Merged
wlgys8 merged 1 commit into
mainfrom
fix/117-linux-default-tbb
Oct 13, 2026
Merged

wlgys8 merged 1 commit into
mainfrom
fix/117-linux-default-tbb

Conversation

@wlgys8

@wlgys8 wlgys8 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Enable Intel TBB by default in Linux runtime installations for both CUDA and ROCm.
  • Include TBB in the full ROCm development installation; retain existing CUDA --all behavior and explicit --tbb compatibility.
  • Keep non-Linux runtime defaults unchanged and update the bilingual installation guides and help text.

Fixes #117

Validation

  • Passed: prek run --all-files
  • Passed: sh -n install.sh
  • Passed: git diff --check
  • Installer behavior was verified with 13 temporary regression tests, removed before commit as requested.
  • Strict Chinese and English Sphinx builds are blocked by unrelated task configs referencing unregistered g1-walk-slope-* environments during environment overview generation.

Include TBB in the full ROCm installation and document the Linux default while preserving the explicit --tbb option.

Fixes #117

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The installer and docs changes correctly and consistently enable TBB by default on Linux across all sync paths while leaving non-Linux defaults unchanged, with no defects found.

0 open findings

What changed in this PR

This PR resolves issue #117 by making Intel TBB install by default on Linux, so Numba parallel manager kernels use the TBB threading layer (avoiding the OpenMP per-region thread-wakeup overhead on many-core hosts) without requiring the explicit --tbb flag. It fits into the installer bootstrap flow in install.sh and keeps --tbb as a compatibility/opt-in flag for other platforms, updating the bilingual installation guides to match.

Changes:

  • Detect Linux in install.sh and set TBB=1, assembling a shared TBB_EXTRA appended to the default sync and the --all ROCm sync (CUDA --all already covers TBB via --all-extras).
  • Update the installer header comment and --tbb help text to state TBB is default on Linux.
  • Update the English and Chinese installation guides to document the new Linux default and that other platforms are unaffected.
File Description
install.sh Adds a Linux case arm setting TBB=1, builds a reusable TBB_EXTRA, and appends it to the ROCm --all and default syncs; updates header comment and help text.
docs/​source/​en/​user_guide/​getting_started/​installation.md Documents the Linux-default TBB behavior (incl. --all and both GPU profiles) and clarifies the --tbb flag is now explicit/opt-in.
docs/​source/​zh_CN/​user_guide/​getting_started/​installation.md Mirrors the English doc updates for the Chinese installation guide.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@wlgys8
wlgys8 merged commit 64f7f28 into main Oct 13, 2026
7 checks passed
@wlgys8
wlgys8 deleted the fix/117-linux-default-tbb branch October 13, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install.sh 在 Linux 下默认安装 Intel TBB

2 participants