Repository navigation
fix(install): enable TBB by default on Linux - #119
Conversation
Include TBB in the full ROCm installation and document the Linux default while preserving the explicit --tbb option. Fixes #117
There was a problem hiding this comment.
🟢 Approval recommended
The installer and docs changes correctly and consistently enable TBB by default on Linux across all sync paths while leaving non-Linux defaults unchanged, with no defects found.
0 open findings
What changed in this PR
This PR resolves issue #117 by making Intel TBB install by default on Linux, so Numba parallel manager kernels use the TBB threading layer (avoiding the OpenMP per-region thread-wakeup overhead on many-core hosts) without requiring the explicit --tbb flag. It fits into the installer bootstrap flow in install.sh and keeps --tbb as a compatibility/opt-in flag for other platforms, updating the bilingual installation guides to match.
Changes:
- Detect Linux in
install.shand setTBB=1, assembling a sharedTBB_EXTRAappended to the default sync and the--allROCm sync (CUDA--allalready covers TBB via--all-extras). - Update the installer header comment and
--tbbhelp text to state TBB is default on Linux. - Update the English and Chinese installation guides to document the new Linux default and that other platforms are unaffected.
| File | Description |
|---|---|
| install.sh | Adds a Linux case arm setting TBB=1, builds a reusable TBB_EXTRA, and appends it to the ROCm --all and default syncs; updates header comment and help text. |
| docs/source/en/user_guide/getting_started/installation.md | Documents the Linux-default TBB behavior (incl. --all and both GPU profiles) and clarifies the --tbb flag is now explicit/opt-in. |
| docs/source/zh_CN/user_guide/getting_started/installation.md | Mirrors the English doc updates for the Chinese installation guide. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Fixes #117
Validation