fix(deps): restore ROCm runtime dependencies - #1650
Merged
Merged
Conversation
TATP-233
force-pushed
the
fix/rocm-runtime-dependencies
branch
from
September 26, 2026 18:19
f2f2574 to
ca11abe
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numba>=0.67andprettytable>=3.10topyproject.rocm.toml.uv.rocm.lock, addingnumba,prettytable, andllvmlite.Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
uv run ruff format tests/scripts/test_rocm_dependency_profile.py uv run ruff check tests/scripts/test_rocm_dependency_profile.py uv run pytest -q tests/scripts/test_rocm_dependency_profile.py # ROCm profile lock consistency (active manifests temporarily swapped, then restored): cp pyproject.toml /tmp/unilab-default-pyproject.toml cp uv.lock /tmp/unilab-default-uv.lock cp pyproject.rocm.toml pyproject.toml cp uv.rocm.lock uv.lock uv lock --check --no-progress cp /tmp/unilab-default-pyproject.toml pyproject.toml cp /tmp/unilab-default-uv.lock uv.lock make check make test-allmake test-allresult: 1549 passed, 27 skipped, 604 deselected; benchmark smoke passed 35/35 module-mode and 36/36 script-mode imports. The first local attempt encountered errors from an ignored, pre-existingscripts/benchmark/outputs/directory; that unrelated local data was temporarily moved aside and restored before the successful final-head run.Remote Linux ROCm validation in an isolated worktree:
The ROCm smoke completed 2/2 SAC iterations on GPU 7. GPU 0-6 jobs were not modified, and no validation process remained afterward.
Remote CI route:
main: current-head CI recorded below after the run starts.Impact
make sync-rocmArtifacts
Checklist
Follow-up noted in #1649: cold ROCm first-update compile can slightly exceed the current 30-second inference coordination timeout. That behavior is outside this dependency-profile PR.