Skip to content

chore(offpolicy): remove inference request timeout config - #1658

Merged
TATP-233 merged 1 commit into
mainfrom
remove-offpolicy-request-timeout
Sep 26, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
remove-offpolicy-request-timeout

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • Remove training.inference_request_timeout_sec from all SAC, FlashSAC, and WarpSAC owner configs.
  • Remove timeout-specific task overrides, tests, comments, and stale cold-start documentation.
  • Update the Newton documentation to describe learner-owned warmup plus the collector-ready handshake rather than a collector tick timeout.
  • Keep the change strict: no compatibility aliases or compatibility layer.

Follow-up to unilabsim/unilab_rl#50. The upstream change has not been released yet, so local validation installed unilab_rl from the sibling checkout as an editable dependency.

Testing

  • uv run --no-sync pytest tests/algos/test_offpolicy_double_buffer_runner.py tests/config/test_g1_motion_tracking_owners.py -q
  • UV_NO_SYNC=1 make check

Both passed. A local UV_NO_SYNC=1 make test also had 1565 passed, 27 skipped; its single failure is the pre-existing benchmark documentation contract failure on unmodified main (_num_envs, num_steps, and warmup_steps in scripts/benchmark/outputs/env_step/env_step_breakdown.md), reproduced independently before this change.

@TATP-233
TATP-233 merged commit d64d80b into main Sep 26, 2026
7 of 8 checks passed
@TATP-233
TATP-233 deleted the remove-offpolicy-request-timeout branch September 26, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant