fix: format release artifact references#751
Open
svvarom wants to merge 4 commits into
Open
Conversation
Signed-off-by: Swarom Muley <smuley@nvidia.com>
Signed-off-by: Swarom Muley <smuley@nvidia.com>
Contributor
|
Signed-off-by: Swarom Muley <smuley@nvidia.com>
svvarom
changed the title
svvarom
marked this pull request as ready for review
July 17, 2026 05:36
Contributor
📝 WalkthroughWalkthroughThe release workflow updates Slack notifications to use release-specific container and Helm destinations, and formats wheel versions, container tags, and Helm install commands in fenced code blocks. ChangesRelease notifications
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
| lines.push("*:helm: Helm chart published:*"); | ||
| lines.push(`- ${chart}: ${process.env.CHART_VERSION}`); | ||
| lines.push("```"); | ||
| lines.push(`nemo-platform:${process.env.CHART_VERSION}`); |
Contributor
There was a problem hiding this comment.
helm nightly is also oci://<registry>/chart --version <version>
Then it's an argument to helm install if you wanted to really follow the thread.
Contributor
Author
There was a problem hiding this comment.
Updated it to print something like helm install nemo-platform oci://ghcr.io/nvidia-nemo/nemo-platform/nemo-platform --version 0.2.0-nightly-20260717040515
Signed-off-by: Swarom Muley <smuley@nvidia.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yaml:
- Around line 1226-1228: Update the helmInstall value in the release artifact
construction to emit only the chart reference
`nemo-platform:${process.env.CHART_VERSION}` instead of a Helm install command,
while preserving the existing chart version interpolation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1eb94c22-7b71-4985-8008-5afcb69c3ed2
📒 Files selected for processing (1)
.github/workflows/release.yaml
crookedstorm
approved these changes
Jul 17, 2026
crookedstorm
left a comment
crookedstorm
left a comment
Contributor
There was a problem hiding this comment.
Let's give it a shot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-complete notification currently mixes linked bullet rows with label/value separators. This makes the artifact list harder to scan, leaves container rows unusable as copyable image references, and does not show how to install the published Helm chart.
Before
SDK:
Containers:
Helm:
After
SDK:
Containers:
Helm nightly:
Helm stable:
Each artifact section now uses a code block: Python requirement syntax for SDK wheels, full registry references for containers, and a directly runnable install command for Helm. Nightly containers and Helm charts use GHCR, while stable containers and Helm charts use their public NVIDIA registries. Artifact builds, publishing, and readiness checks are unchanged.
Human attention needed
actionlintpassed, the workflow YAML parses, andgit diff --checkpassednemo-platformas the release nameSummary by CodeRabbit
helm installcommands tailored to the release type.