Skip to content

fix: format release artifact references #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svvarom wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: format release artifact references #751

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2138856
fix: format release container references
svvarom Jul 17, 2026
3198887
test: remove notification regression test
svvarom Jul 17, 2026
68b86e7
fix: format all release artifact references
svvarom Jul 17, 2026
8e41cee
fix: show helm install commands
svvarom Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,11 +1158,12 @@ jobs:
WHEEL_CATALOG: ${{ env.RELEASE_WHEELS_JSON }}
WHEEL_VERSION: ${{ needs.plan-release.outputs.wheel_version }}
CONTAINER_IDS: ${{ needs.plan-release.outputs.container_ids }}
RELEASE_NIGHTLY_CONTAINER_REGISTRY: ${{ env.RELEASE_NIGHTLY_CONTAINER_REGISTRY }}
RELEASE_STABLE_CONTAINER_REGISTRY: ${{ env.RELEASE_STABLE_CONTAINER_REGISTRY }}
RELEASE_NIGHTLY_HELM_OCI_REGISTRY: ${{ env.RELEASE_NIGHTLY_HELM_OCI_REGISTRY }}
RELEASE_STABLE_HELM_REPOSITORY: ${{ env.RELEASE_STABLE_HELM_REPOSITORY }}
INCLUDE_HELM: ${{ needs.plan-release.outputs.include_helm }}
CHART_VERSION: ${{ needs.stage-helm.outputs.chart_version }}
NIGHTLY_WHEEL_INDEX: ${{ env.RELEASE_NIGHTLY_WHEEL_INDEX }}
STABLE_WHEEL_INDEX: ${{ env.RELEASE_STABLE_WHEEL_INDEX }}
NGC_CATALOG_BASE: ${{ env.RELEASE_NGC_CATALOG_BASE }}
POLL_RESULT: ${{ needs.poll-final-release.result }}
GITHUB_RELEASE_RESULT: ${{ needs.create-github-release.result }}
DEPLOYMENT_RESULT: ${{ needs.signal-deployment.result }}
Expand Down Expand Up @@ -1201,32 +1202,32 @@ jobs:
lines.push("", "*Artifacts published:*");
if (wheelIds.length > 0) {
lines.push("*:python: Wheels published:*");
lines.push("```");
for (const wheelId of wheelIds) {
const wheel = wheelCatalog.find((candidate) => candidate.id === wheelId);
const wheelIndex = releaseType === "nightly"
? process.env.NIGHTLY_WHEEL_INDEX
: process.env.STABLE_WHEEL_INDEX;
const wheelUrl = releaseType === "nightly"
? `${wheelIndex}/${wheel.package}/`
: `${wheelIndex.replace(/\/simple$/, "/project")}/${wheel.package}/${process.env.WHEEL_VERSION}/`;
lines.push(`- <${wheelUrl}|${wheel.package}: ${process.env.WHEEL_VERSION}>`);
lines.push(`${wheel.package}==${process.env.WHEEL_VERSION}`);
}
lines.push("```");
}
if (containerIds.length > 0) {
lines.push("*:docker_: Containers published:*");
lines.push("```");
const containerRegistry = releaseType === "stable"
? process.env.RELEASE_STABLE_CONTAINER_REGISTRY
: process.env.RELEASE_NIGHTLY_CONTAINER_REGISTRY;
for (const containerId of containerIds) {
const container = releaseType === "stable"
? `<${process.env.NGC_CATALOG_BASE}/containers/${containerId}|${containerId}>`
: containerId;
lines.push(`- ${container}: ${process.env.RELEASE_LABEL}`);
lines.push(`${containerRegistry}/${containerId}:${process.env.RELEASE_LABEL}`);
}
lines.push("```");
}
if (process.env.INCLUDE_HELM === "true") {
const chart = releaseType === "stable"
? `<${process.env.NGC_CATALOG_BASE}/helm-charts/nemo-platform|nemo-platform>`
: "nemo-platform";
lines.push("*:helm: Helm chart published:*");
lines.push(`- ${chart}: ${process.env.CHART_VERSION}`);
lines.push("```");
const helmInstall = releaseType === "stable"
? `helm install nemo-platform nemo-platform --repo ${process.env.RELEASE_STABLE_HELM_REPOSITORY} --version ${process.env.CHART_VERSION}`
: `helm install nemo-platform ${process.env.RELEASE_NIGHTLY_HELM_OCI_REGISTRY}/nemo-platform --version ${process.env.CHART_VERSION}`;
Comment thread
svvarom marked this conversation as resolved.
lines.push(helmInstall);
lines.push("```");
}
} else {
lines.push(
Expand Down