feat(runtime-v2): add synchronized audio output - #526
Conversation
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
|
Review provenance: this prerequisite contains the model-neutral portions of the Claude review originally posted on #523, including Python 3.10-safe exception notes, duration-scaled mux timeout and terminate/kill recovery, once-only application close, per-sink transaction semantics, exact FPS/audio alignment, and retained cleanup ownership. The original disposition matrix remains at #523 (comment). H3-specific and media-input findings remain on #523. |
|
Split validation complete on head 264840e. Local: focused V2 audio/runtime 174 passed; full ci_cpu 1,975 passed, 2 skipped, 340 deselected; every pre-commit hook passed; standalone FlashDreams sdist/wheel built. Fresh GitHub checks: CPU passed in 8m38s, GPU passed in 17m8s, docs/REUSE/OSRB passed. The PR remains draft and mergeable. |
|
Thanks — this discussion helped separate the model-result contract from the behavior of individual transports. My proposed disposition for #526 is:
So I believe the |
Summary
Extracted from #523 as the model-neutral prerequisite for the MiniMax H3 V2 integration. PR #523 will be stacked on this exact branch head.
This PR contains no MiniMax H3 or Diffusers code, adds no workspace package, and changes no dependency lock data.
Validation
Stack