fix(appium): recover Cordova iOS sync failures#40
Merged
Conversation
Contributor
|
Can you give more context and motivation for PR? What types of problems were happening before? Or mention related/concurrent PRs. |
nan-li
approved these changes
Jun 22, 2026
Contributor
There was a problem hiding this comment.
related to OneSignal/OneSignal-Cordova-SDK#1185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently added logic to disable location for cordova sdk. But with that change the pod installation path uses git method i.e. it will clone the repo to install the pod. For release branches on cordova sdk, it will update the version for the podspec but obviously the version wouldn't be available to use until its merged.
So for testing locally, if user is on a checked-out release branch for cordova, we will patch to use local pod installation.
Summary
OneSignalCordovaDependenciesat the active Cordovarel/*branch.vpx cap syncand refreshesOneSignalXCFrameworkafter repointing the pod.Test plan
Made with Cursor