Skip to content

fix(appium): recover Cordova iOS sync failures #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 1 commit into from
Jun 22, 2026
Merged

fix(appium): recover Cordova iOS sync failures #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions appium/scripts/run-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,24 +578,43 @@ EOF
fi
}

patch_cordova_ios_podfile() {
patch_cordova_ios_podfile_git_branch() {
local podfile="$DEMO_DIR/ios/App/Podfile"
local branch

if [[ ! -f "$podfile" ]]; then
return
fi

PODFILE="$podfile" python3 <<'PY'
branch=$(git -C "$CORDOVA_DIR" rev-parse --abbrev-ref HEAD 2>/dev/null || true)
if [[ "$branch" != rel/* ]]; then
return
fi

info "Repointing OneSignalCordovaDependencies pod to git branch ${branch}..."
PODFILE="$podfile" BRANCH="$branch" python3 <<'PY'
import os
import re
from pathlib import Path

podfile = Path(os.environ["PODFILE"])
branch = os.environ["BRANCH"]
text = podfile.read_text()
pod_line = " pod 'OneSignalCordovaDependencies', :path => '../../node_modules/onesignal-cordova-plugin'"

if "OneSignalCordovaDependencies" not in text:
text = text.replace("target 'App' do\n", f"target 'App' do\n{pod_line}\n", 1)
podfile.write_text(text)
pod_line = (
"pod 'OneSignalCordovaDependencies', "
":git => 'https://github.com/OneSignal/OneSignal-Cordova-SDK.git', "
f":branch => '{branch}'"
)

text, count = re.subn(
r"pod 'OneSignalCordovaDependencies'.*",
pod_line,
text,
)
if count == 0:
raise SystemExit("Unable to find OneSignalCordovaDependencies pod in Podfile")

podfile.write_text(text)
PY
}

Expand Down Expand Up @@ -676,8 +695,6 @@ build_cordova_ios() {
write_cordova_demo_env
setup_cordova_sdk

patch_cordova_ios_podfile

info "Building web bundle (vite)..."
(cd "$DEMO_DIR" && vp run build)

Expand All @@ -696,7 +713,11 @@ build_cordova_ios() {
xattr -w com.apple.xcode.CreatedByBuildSystem true "$DEMO_DIR/ios/App/build" 2>/dev/null || true

info "Syncing Capacitor (also installs/updates Pods)..."
(cd "$DEMO_DIR" && bunx cap sync ios)
if ! (cd "$DEMO_DIR" && vpx cap sync ios); then
patch_cordova_ios_podfile_git_branch
info "Refreshing OneSignalXCFramework after local dependency changes..."
(cd "$DEMO_DIR/ios/App" && pod update OneSignalXCFramework)
fi
mkdir -p "$(dirname "$sync_stamp")"
echo "$sync_hash" > "$sync_stamp"
fi
Expand Down Expand Up @@ -734,7 +755,7 @@ build_cordova_android() {
info "Capacitor sync inputs unchanged, skipping cap sync"
else
info "Syncing Capacitor..."
(cd "$DEMO_DIR" && bunx cap sync android)
(cd "$DEMO_DIR" && vpx cap sync android)
mkdir -p "$(dirname "$sync_stamp")"
echo "$sync_hash" > "$sync_stamp"
fi
Expand Down